Commit ac6064f9 authored by Matt Whitlock's avatar Matt Whitlock Committed by Nicolai Hähnle

st/xa: replace call to dup(2) with fcntl(F_DUPFD_CLOEXEC)

Without this fix, duplicated file descriptors leak into child processes.
See commit aaac913e for one instance
where the same fix was employed.

Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: default avatarMatt Whitlock <freedesktop@mattwhitlock.name>
Reviewed-by: default avatarNicolai Hähnle <nicolai.haehnle@amd.com>
parent 0c060f69
......@@ -27,6 +27,7 @@
*/
#include <unistd.h>
#include <fcntl.h>
#include "xa_tracker.h"
#include "xa_priv.h"
#include "pipe/p_state.h"
......@@ -157,7 +158,7 @@ xa_tracker_create(int drm_fd)
if (!xa)
return NULL;
if (drm_fd < 0 || (fd = dup(drm_fd)) < 0)
if (drm_fd < 0 || (fd = fcntl(drm_fd, F_DUPFD_CLOEXEC, 3)) < 0)
goto out_no_fd;
if (pipe_loader_drm_probe_fd(&xa->dev, fd))
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment