Commit 9f8a2046 authored by Vinson Lee's avatar Vinson Lee Committed by Marge Bot
Browse files

panfrost: Avoid double unlock.

Fix defect reported by Coverity Scan.

Double unlock (LOCK)
double_unlock: pthread_mutex_unlock unlocks dev->indirect_draw_shaders.lock while it is unlocked.

Fixes: 2e6d94c1

 ("panfrost: Add helpers to support indirect draws")
Suggested-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <alyssa@collabora.com>
Signed-off-by: Vinson Lee's avatarVinson Lee <vlee@freedesktop.org>
Part-of: <!14262>
parent 1d6f6f91
Pipeline #470478 passed with stage
in 8 minutes and 56 seconds
......@@ -1168,7 +1168,6 @@ create_indirect_draw_shader(struct panfrost_device *dev,
pan_pack(state, RENDERER_STATE, cfg) {
pan_shader_prepare_rsd(&shader_info, address, &cfg);
}
pthread_mutex_unlock(&dev->indirect_draw_shaders.lock);
draw_shader->push = shader_info.push;
draw_shader->rsd = dev->indirect_draw_shaders.states->ptr.gpu +
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment