Commit 981d07c7 authored by Eric Engestrom's avatar Eric Engestrom Committed by Marge Bot

intel: fix

The script was failing for me (python 3.8), not sure if this is a recent
python version break or not as I don't know how often people have been
running this script:

    Processing ./gen9.xml... Traceback (most recent call last):
      File "./", line 177, in <module>
      File "./", line 170, in main
        genxml[:] = enums + sorted_structs.values() + instructions + registers
    TypeError: can only concatenate list (not "odict_values") to list

Turning the odict into a list fixes it for me, and the resulting xml
file are identical to before :)

Fixes: 903e142f ("genxml: add a sorting script")
Signed-off-by: Eric Engestrom's avatarEric Engestrom <>
Reviewed-by: Lionel Landwerlin's avatarLionel Landwerlin <>
Part-of: <!5352>
parent bfff330f
Pipeline #156794 passed with stages
in 10 minutes and 21 seconds
......@@ -163,7 +163,7 @@ def process(filename):
for r in registers:
r[:] = sorted(r.getchildren(), key=get_start)
genxml[:] = enums + sorted_structs.values() + instructions + registers
genxml[:] = enums + list(sorted_structs.values()) + instructions + registers
with open(filename, 'w') as f:
f.write('<?xml version="1.0" ?>\n')
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment