Commit 8ad3d8b1 authored by Bas Nieuwenhuizen's avatar Bas Nieuwenhuizen
Browse files

radv: Fix condition for skipping the continue CS.

We need the continue CS for referencing the tess/GDS/sample position BOs.

Fixes: 46e52df3 "radv: add tessellation ring allocation support. (v2)"
Fixes: e1dc3ab7 "radv/gfx10: allocate GDS/OA buffer objects for NGG streamout"
Fixes: 1171b304

 "radv: overhaul fragment shader sample positions."
Reviewed-by: Samuel Pitoiset's avatarSamuel Pitoiset <>
parent 4712fdf7
Pipeline #68102 passed with stages
in 17 minutes and 26 seconds
......@@ -2682,7 +2682,8 @@ radv_get_preamble_cs(struct radv_queue *queue,
*initial_full_flush_preamble_cs = queue->initial_full_flush_preamble_cs;
*initial_preamble_cs = queue->initial_preamble_cs;
*continue_preamble_cs = queue->continue_preamble_cs;
if (!scratch_size && !compute_scratch_size && !esgs_ring_size && !gsvs_ring_size)
if (!scratch_size && !compute_scratch_size && !esgs_ring_size && !gsvs_ring_size &&
!needs_tess_rings && !needs_gds && !needs_sample_positions)
*continue_preamble_cs = NULL;
return VK_SUCCESS;
  • mentioned in merge request !2219 (merged)

    Toggle commit list
  • This commit is a candidate for 19.1 release, but unfortunately it depends on commit e1dc3ab7 to build, which is not part of the branch (and it depends also on other commits not in the branch).

    Hence, unless a specific backport is provided for 19.1, I'm discarding it.

Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment