Commit 7eb49668 authored by Francisco Jerez's avatar Francisco Jerez

i965/fs: Allow spilling of non-contiguous registers.

This should be working fine now.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94997Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
parent 6fc5dd5b
...@@ -835,30 +835,13 @@ fs_visitor::choose_spill_reg(struct ra_graph *g) ...@@ -835,30 +835,13 @@ fs_visitor::choose_spill_reg(struct ra_graph *g)
*/ */
foreach_block_and_inst(block, fs_inst, inst, cfg) { foreach_block_and_inst(block, fs_inst, inst, cfg) {
for (unsigned int i = 0; i < inst->sources; i++) { for (unsigned int i = 0; i < inst->sources; i++) {
if (inst->src[i].file == VGRF) { if (inst->src[i].file == VGRF)
spill_costs[inst->src[i].nr] += loop_scale; spill_costs[inst->src[i].nr] += loop_scale;
/* Register spilling logic assumes full-width registers; smeared
* registers have a width of 1 so if we try to spill them we'll
* generate invalid assembly. This shouldn't be a problem because
* smeared registers are only used as short-term temporaries when
* loading pull constants, so spilling them is unlikely to reduce
* register pressure anyhow.
*/
if (!inst->src[i].is_contiguous()) {
no_spill[inst->src[i].nr] = true;
}
}
} }
if (inst->dst.file == VGRF) { if (inst->dst.file == VGRF)
spill_costs[inst->dst.nr] += inst->regs_written * loop_scale; spill_costs[inst->dst.nr] += inst->regs_written * loop_scale;
if (!inst->dst.is_contiguous()) {
no_spill[inst->dst.nr] = true;
}
}
switch (inst->opcode) { switch (inst->opcode) {
case BRW_OPCODE_DO: case BRW_OPCODE_DO:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment