Commit 7a46b2d6 authored by Gert Wollny's avatar Gert Wollny Committed by Gert Wollny

meson, install_megadrivers: Also remove stale symlinks

os.path.exists doesn't return True for stale symlinks, but they are in
the way later, when a link/file with the same name is to be created.
For instance it is conceivable that the pointed to file is replaced by
a file with a new name, and then the symlink is dead.

To handle this check specifically for all existing symlinks to be
removed. (This bugged me for some time with a link
always being in the way of installing this file)

v2: use only os.lexist and replace all instances of os.exist (Dylan Baker)

v3: handle directory check correctly (Eric Engestrom)

Fixes: f7f1b30f
       ("meson: extend install_megadrivers script to handle symmlinking")

Reviewed-by: Eric Engestrom <>(v2 minus dir check)
Reviewed-by: Dylan Baker's avatarDylan Baker <>
Signed-off-by: Gert Wollny's avatarGert Wollny <>
parent 5eb4b384
......@@ -43,13 +43,15 @@ def main():
master = os.path.join(to, os.path.basename(args.megadriver))
if not os.path.exists(to):
if os.path.lexists(to):
shutil.copy(args.megadriver, master)
for driver in args.drivers:
abs_driver = os.path.join(to, driver)
if os.path.exists(abs_driver):
if os.path.lexists(abs_driver):
print('installing {} to {}'.format(args.megadriver, abs_driver)), abs_driver)
......@@ -60,7 +62,7 @@ def main():
name, ext = os.path.splitext(driver)
while ext != '.so':
if os.path.exists(name):
if os.path.lexists(name):
os.symlink(driver, name)
name, ext = os.path.splitext(name)
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment