Commit 7898721c authored by Vinson Lee's avatar Vinson Lee Committed by Marge Bot
Browse files

panfrost: Fix memory leaks on unit test failures.

Change ASSERT_EQ to EXPECT_EQ to avoid aborting before freeing memory.

Fix defects reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable tiled going out of scope leaks the storage it points to.
leaked_storage: Variable linear going out of scope leaks the storage it points to.
leaked_storage: Variable ref going out of scope leaks the storage it points to.

Fixes: bb6c14a6

 ("panfrost: Unit test u-interleaved tiling routines")
Suggested-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Vinson Lee's avatarVinson Lee <vlee@freedesktop.org>
Part-of: <!16127>
parent f5bc062f
Pipeline #569111 waiting for manual action with stages
......@@ -160,9 +160,9 @@ test(unsigned width, unsigned height, unsigned rx, unsigned ry,
dst_stride, src_stride, format, store);
if (store)
ASSERT_EQ(memcmp(ref, tiled, bpp * tiled_width * tiled_height), 0);
EXPECT_EQ(memcmp(ref, tiled, bpp * tiled_width * tiled_height), 0);
else
ASSERT_EQ(memcmp(ref, linear, bpp * rw * linear_stride), 0);
EXPECT_EQ(memcmp(ref, linear, bpp * rw * linear_stride), 0);
free(ref);
free(tiled);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment