Commit 09b2bd1d authored by Alejandro Piñeiro's avatar Alejandro Piñeiro Committed by Marge Bot

broadcom/compiler: remove v3d_fs_key depth_enabled field.

It is not used right now, so keeping it adds some noise/confusion.

So far configuring Z test are done through the CFG_BITS. See
v3dX(emit_state) at v3dx_emit.c for v3d, and pack_cfg_bits at
v3dv_pipeline.c for v3dv. There flags like z_updates_enable and others
are filled up.

That key field seems like a leftover coming from using vc4 as
reference, as that driver defines and uses a field with name name.
Reviewed-by: Iago Toral's avatarIago Toral Quiroga <itoral@igalia.com>
Part-of: <!7421>
parent 21ffacff
Pipeline #222882 waiting for manual action with stages
in 26 seconds
...@@ -360,7 +360,6 @@ struct v3d_key { ...@@ -360,7 +360,6 @@ struct v3d_key {
struct v3d_fs_key { struct v3d_fs_key {
struct v3d_key base; struct v3d_key base;
bool depth_enabled;
bool is_points; bool is_points;
bool is_lines; bool is_lines;
bool line_smoothing; bool line_smoothing;
......
...@@ -1145,11 +1145,6 @@ pipeline_populate_v3d_fs_key(struct v3d_fs_key *key, ...@@ -1145,11 +1145,6 @@ pipeline_populate_v3d_fs_key(struct v3d_fs_key *key,
} }
} }
const VkPipelineDepthStencilStateCreateInfo *ds_info =
pCreateInfo->pDepthStencilState;
key->depth_enabled = (ds_info == NULL ? false : ds_info->depthTestEnable);
/* Vulkan doesn't support alpha test */ /* Vulkan doesn't support alpha test */
key->alpha_test = false; key->alpha_test = false;
key->alpha_test_func = COMPARE_FUNC_NEVER; key->alpha_test_func = COMPARE_FUNC_NEVER;
......
...@@ -559,8 +559,6 @@ v3d_update_compiled_fs(struct v3d_context *v3d, uint8_t prim_mode) ...@@ -559,8 +559,6 @@ v3d_update_compiled_fs(struct v3d_context *v3d, uint8_t prim_mode)
key->sample_alpha_to_one = v3d->blend->base.alpha_to_one; key->sample_alpha_to_one = v3d->blend->base.alpha_to_one;
} }
key->depth_enabled = (v3d->zsa->base.depth.enabled ||
v3d->zsa->base.stencil[0].enabled);
if (v3d->zsa->base.alpha.enabled) { if (v3d->zsa->base.alpha.enabled) {
key->alpha_test = true; key->alpha_test = true;
key->alpha_test_func = v3d->zsa->base.alpha.func; key->alpha_test_func = v3d->zsa->base.alpha.func;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment