Skip to content
  • Caio Oliveira's avatar
    nir: Add scoped_memory_barrier intrinsic · 73572abc
    Caio Oliveira authored
    
    
    Add a NIR instrinsic that represent a memory barrier in SPIR-V /
    Vulkan Memory Model, with extra attributes that describe the barrier:
    
    - Ordering: whether is an Acquire or Release;
    - "Cache control": availability ("ensure this gets written in the memory")
      and visibility ("ensure my cache is up to date when I'm reading");
    - Variable modes: which memory types this barrier applies to;
    - Scope: how far this barrier applies.
    
    Note that unlike in SPIR-V, the "Storage Semantics" and the "Memory
    Semantics" are split into two different attributes so we can use
    variable modes for the former.
    
    NIR passes that took barriers in consideration were also changed
    
    - nir_opt_copy_prop_vars: clean up the values for the mode of an
      ACQUIRE barrier.  Copy propagation effect is to "pull up a load" (by
      not performing it), which is what ACQUIRE restricts.
    
    - nir_opt_dead_write_vars and nir_opt_combine_writes: clean up the
      pending writes for the modes of an RELEASE barrier.  Dead writes
      effect is to "push down a store", which is what RELEASE restricts.
    
    - nir_opt_access: treat the ACQUIRE and RELEASE as a full barrier for
      the modes.  This is conservative, but since this is a GL-specific
      pass, doesn't make a difference for now.
    
    v2: Fix the scoped barrier handling in copy propagation.  (Jason)
        Add scoped barrier handling to nir_opt_access and
        nir_opt_combine_writes.  (Rhys)
    
    Reviewed-by: default avatarJason Ekstrand <jason@jlekstrand.net>
    Reviewed-by: default avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
    73572abc