-
Original patches wrote by Ella Stanforth. Alejandro Piñeiro main changes (skipping the small fixes/typos): * Reduced the list of supported formats to VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM and VK_FORMAT_G8_B8R8_2PLANE_420_UNORM, that are the two only mandatory by the spec. * Fix format features exposed with YCbCr: * Disallow some features not supported with YCbCr (like blitting) * Disallow storage image support. Not clear if really useful. Even if there are CTS tests, there is an ongoing discussion about the possibility to remove them. * Expose VK_FORMAT_FEATURE_COSITED_CHROMA_SAMPLES_BIT, that is mandatory for the formats supported. * Not expose VK_FORMAT_FEATURE_2_MIDPOINT_CHROMA_SAMPLES_BIT. Some CTS tests are failing right now, and it is not mandatory. Likely to be revisit later. * We are keeping VK_FORMAT_FEATURE_2_DISJOINT_BIT and VK_FORMAT_FEATURE_2_MIDPOINT_CHROMA_SAMPLES_BIT. Even if they are optional, it is working with the two formats that we are exposing. Likely that will need to be refined if we start to expose more formats. * create_image_view: don't use hardcoded 0x70, but instead doing an explicit bit or of VK_IMAGE_ASPECT_PLANE_0/1/2_BIT * image_format_plane_features: keep how supported aspects and separate stencil check is done. Even if the change introduced was correct (not sure about that though), that change is unrelated to this work * write_image_descriptor: add additional checks for descriptor type, to compute properly the offset. * Cosmetic changes (don't use // for comments, capital letters, etc) * Main changes coming from the review: * Not use image aliases. All the info is already on the image planes, and some points of the code were confusing as it was using always a hardcoded plane 0. * Squashed the two original main patches. YCbCr conversion was leaking on the multi-planar support, as some support needed info coming from the ycbcr structs. * Not expose the extension on Android, and explicitly assert that we expect plane_count to be 1 always. * For a full list of review changes see MR#19950 Signed-off-by: Ella Stanforth <estanforth@igalia.com> Signed-off-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <!19950>
18319a23