--max-fails option is not stopping execution as expected
Adding "--max-fails" option on cli is supposed to stop execution after N+1 failures. Crashes are counted but not expected failures.
Recently this pipeline https://gitlab.freedesktop.org/mesa/mesa/-/pipelines/1268477 ran this command
deqp-runner suite --suite /install/deqp-lima-mali450-piglit.toml --output //results --skips /install/all-skips.txt /install/lima-skips.txt /install/gbm-skips.txt --flakes /install/lima-flakes.txt --testlog-to-xml /deqp/executor/testlog-to-xml --fraction-start 1 --fraction 2 --jobs 4 --baseline /install/lima-fails.txt --max-fails 40
The --max-fails
option counted total failures but it didn't stop execution as expected. Here's part of the log
[0m2024-09-10 16:13:52.990348: [0m[31mERROR - Test spec@glsl-1.10@linker@override-builtin-const-05: Crash: See "//results/piglit.spec@glsl-1.10@linker@override-builtin-const-05.log"
[0m2024-09-10 16:13:52.990353: [0mToo many failures: 770
[0m2024-09-10 16:13:52.990358: [0m[31mERROR - Test spec@ext_gpu_shader4@execution@texelfetchoffset@vs-texelfetch-isampler1d: Crash: See "//results/piglit.spec@ext_gpu_shader4@execution@texelfetchoffset@vs-texelfetch-isampler1d.log"
[0m2024-09-10 16:13:52.990363: [0mToo many failures: 771
[0m2024-09-10 16:13:52.990368: [0m[31mERROR - Test spec@glsl-1.20@execution@built-in-functions@glsl-const-builtin-equal-06: Crash: See "//results/piglit.spec@glsl-1.20@execution@built-in-functions@glsl-const-builtin-equal-06.log"
[0m2024-09-10 16:13:52.990373: [0mPass: 1587, Crash: 1402, ExpectedFail: 186, Skip: 9919, Duration: 7:41, Remaining: 0
Find a way to fix this so that it stops deqp-runner entirely.
Edited by Deborah Brouwer