GitLab

glib documentation says G_SOURCE_FUNC() macro should be used to suppress
the warning about incompatible function types when the function will be
cast back to the correct type before it is called by the GSource.

An application using more than one NiceAgent instance may crash due to
a race in gUPnP.

Fix is to be released in gUPnP 1.1.2 / 1.0.4:

https://gitlab.gnome.org/GNOME/gupnp/commit/0123e574595e0a547ce26422633df72d63d3d0e0

libnice.so created by autotools has its symbols bound to the default
'Base' version node, whereas Meson build arbitrarily introduced a
version node named 'libnice'. This breaks tools like dpkg-gensymbols
that track changes in exported symbols through several releases of the
library.

Remove 'libnice' version and revert back to using unspecified version.

Errors reported by lintian -EvIL -pedantic.

This is because Docker doesn't have IPv6 by default.

Jan Tojnar authored Jan 03, 2019 and Olivier Crête committed Jan 03, 2019

On Nix, test-gstreamer fails with

	36/38 test-gstreamer                          FAIL     0.07 s (exit status 1)

	--- command ---
	BUILT_WITH_MESON='1' /build/libnice/build/tests/nice-test-gstreamer
	--- stdout ---
	Running suite(s): nice_gstreamer_test
	0%: Checks: 1, Failures: 1, Errors: 0
	../libs/gst/check/gstcheck.c:466:F:nice:buffer_list_test:0: Could not create a 'nicesink' element
	Check suite udpsink ran in 0.002s (tests failed: 1)
	-------

Let’s add the build directory to GST_PLUGIN_SYSTEM_PATH_1_0, so that
the test can find the built GStreamer element.

Meson needs to see all libraries a target depends on so that it can add
each to PATH when running "meson test".

Avoids "*.dll was not found" errors.

Jose Antonio Santos Cadenas authored Jan 29, 2016 and Olivier Crête committed Dec 27, 2018

When a peer reflexive candidate is discovered, it is added to the
list of connection checks, but is is not nominated by default.

This causes a problem if parent pair is already nominated and
the remote peer does not send more requests because it has already
selected a candidate. (i.e.: This is the case of WebRtc in Firefox)

Olivier Crête authored Nov 16, 2018 and Olivier Crête committed Dec 27, 2018

We have to check this list every time candidates are added.

Olivier Crête authored Nov 16, 2018 and Olivier Crête committed Dec 27, 2018

Candidates could also be dribbled.

Olivier Crête authored Nov 16, 2018 and Olivier Crête committed Dec 27, 2018

We check the size regularly, so add a little efficiency.

Allow building of g-i with static libs which should
work since Meson 0.49 and sufficiently recent
gobject-introspection (>= 1.58.1). If g-i is too
old people will get a suitable error message and
can disable g-i via build options.

Jakub Adam authored Dec 18, 2018 and Olivier Crête committed Dec 21, 2018

Prevents Meson error:

ERROR:  requires argument not a string, library with pkgconfig-generated
file or pkgconfig-dependency object, got <InternalDependency null: True>

Requires Meson 0.49.

Jakub Adam authored Dec 17, 2018 and Olivier Crête committed Dec 21, 2018

When building libnice with glib fallback, its 'libgio_dep' internal
dependency doesn't provide all needed include and library search paths.

To avoid unresolved header files and linker errors in such case,
'libglib_dep', 'libmodule_dep' and 'libgobject_dep' from glib submodule
must be pulled in as well.

The problem should be fixed in GLib 2.60.

nice_stream_close() calls agent_find_stream(), which iterates over
agent->streams list.

Therefore, when we're freeing agent->streams in a loop, we must also
delete the respective GSList item from the list at the end of each
iteration. Otherwise agent_find_stream() would stumble over already
deleted NiceStream instance the next time it gets called.

Fixes random crashes when running test-different-number-streams on
Windows.

Fixes failing test cases on Windows.

The underlying GSocket implementation on Windows returns an error when
the user-provided buffer isn't large enough to fit the whole datagram
received on a message-oriented socket.

When this occurs, in order to preserve identical behavior of udp-bsd
NiceSocket across platforms, we have to mute the error and set the
received message length to the size of the provided NiceInputMessage.
Any excess portion of the message gets discarded.

Fixed udp-bsd test on Windows.

GLib 2.48 is required in order to use G_IO_ERROR_MESSAGE_TOO_LARGE.