- 09 Aug, 2019 3 commits
-
-
Hans de Goede authored
Only log 1 error for consecutive flip failures, instead of filling the log and the disk with errors for each attempted flip. Despite our best efforts we may end up with a BO which gets refused when we try to import it as a framebuffer, see e.g. : https://bugs.freedesktop.org/show_bug.cgi?id=111306 This should not happen, but as the above bugs shows sometimes it does and chances are it will happen again. Note ideally we should check if the import is possible at ms_present_check_flip time, like the amdgpu code is doing since: xorg/driver/xf86-video-amdgpu!35 but that requires a chunk of refactoring work on the modesetting driver, so for now this will have to do. Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
Before this commit ms_do_pageflip logged a single error for both the drmmode_bo_import failure path as well as for the queue_flip_on_crtc path. This commit splits this into 2 separate error logs so that it is clear what the cause of the flip-failure is. Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
Currently on present-flip failures we log 2 messages for each failure, 1 from ms_do_pageflip and then another one from ms_present_flip which is the caller of ms_do_pageflip. This commit adds a log_prefix argument to ms_do_pageflip so that its log messages can show if it is a DRI2 or a Present flip which fails and removes the redundant error message from ms_present_flip. Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
- 07 Aug, 2019 1 commit
-
-
Dave Airlie authored
This is a modified version of a patch we've been carry-ing in Fedora and RHEL for years now. This patch automatically adds secondary GPUs to the master as output sink / offload source making e.g. the use of slave-outputs just work, with requiring the user to manually run "xrandr --setprovideroutputsource" before he can hookup an external monitor to his hybrid graphics laptop. There is one problem with this patch, which is why it was not upstreamed before. What to do when a secondary GPU gets detected really is a policy decission (e.g. one may want to autobind PCI GPUs but not USB ones) and as such should be under control of the Desktop Environment. Unconditionally adding autobinding support to the xserver will result in races between the DE dealing with the hotplug of a secondary GPU and the server itself dealing with it. However we've waited for years for any Desktop Environments to actually start doing some sort of autoconfiguration of secondary GPUs and there is sti...
-
- 06 Aug, 2019 5 commits
-
-
Hans de Goede authored
As discussed in issue #829 the "mi: Shortcut miDoCopy/miCopyArea based on clipList" change leads to pointer-trails (area under pointer not restored when it moves) when using a software cursor. Checking pGC->pCompositeClip instead of pDstDrawable->clipList fixes this problem. Fixes: #829 Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
The miPointerSpriteFunc swcursor code expects there to only be a single framebuffer and when the cursor moves it will undo the damage of the previous draw, potentially overwriting what ever is there in a new framebuffer installed after a flip. This leads to all kind of artifacts, so we need to disable pageflipping when a swcursor is used. The code for this has shamelessly been copied from the xf86-video-amdgpu code. Fixes: xorg/xserver#828Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
Fix the following compiler warning: drmmode_display.c: In function ‘drmmode_create_bo’: drmmode_display.c:1019:9: warning: ISO C90 forbids mixed declarations and code [ 1019 | uint32_t num_modifiers; | ^~~~~~~~ Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
When the pixmapPrivateKeyRec was moved from a global to being embedded inside the drmmode_rec these 2 where missed, clean them up. Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
The modesetting driver (which now often is used with Intel GPUs), relies on DRI2ScreenInit() to setup the DRI and VDPAU driver names. Before this commit it would always assign the same name to the 2 names, but the VDPAU driver for i965 GPUs should be va_gl. This commit adds a special case for the i965 case, replacing the VDPAU driver name with "va_gl" if the GPU is using the i965 driver for DRI. Note this commit adds a FIXME comment for a related memory leak, that leak was already present and fixing it falls outside of the scope of this commit. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1413733 Cc: kwizart@gmail.com Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
- 05 Aug, 2019 1 commit
-
-
Ross Burton authored
This script generates a header that has a comment containing the build path for no real reason. As this source can end up deployed on targets in debug packages this means there is both potentially sensitive information leakage about the build environment, and a source of change for reproducible builds.
-
- 04 Aug, 2019 1 commit
-
-
Alan Coopersmith authored
Stop trying to link to a shared library we no longer build Fixes: commit c1703cdf - "xfree86: Link fb statically" Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 31 Jul, 2019 2 commits
-
-
Olivier Fourdan authored
Building Xwayland without glamor support would raise a warning at build time: xwayland.c: In function ‘xwl_screen_init’: xwayland.c:980:10: warning: unused variable ‘use_eglstreams’ 980 | Bool use_eglstreams = FALSE; | ^~~~~~~~~~~~~~ When building without glamor support, we cannot have EGL Streams support either, the two being related. So we do not need to declare the variable `use_eglstreams` if glamor is not enabled. Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com>
-
Olivier Fourdan authored
When building Xwayland without glamor support enabled using automake, the build would fail at link time trying to find `glamor_block_handler`: /usr/bin/ld: xwayland-glx.o: in function `egl_drawable_wait_x': hw/xwayland/xwayland-glx.c:102: undefined reference to `glamor_block_handler' Make sure we don't try to build `xwayland-glx.c` without glamor in the Xwayland Makefile. Note: Meson build is fine because it's already build only with glamor enabled. Fixes: commit 84692415 - "xwayland: Add EGL-backed GLX provider" Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com>
-
- 23 Jul, 2019 4 commits
-
-
Jon Turney authored
-
Adam Jackson authored
There's no real benefit to leaving this loadable, virtually every driver is going to load it. Reviewed-by:
Jon Turney <jon.turney@dronecode.org.uk>
-
Olivier Fourdan authored
Both `gbm_bo_create()` and `gbm_bo_create_with_modifiers()` can fail and return `NULL`. If that occurs, `xwl_glamor_gbm_create_pixmap()` will not create a pixmap for the (NULL) GBM bo, but would still try to free the bo which leads to a crash in mesa: [...] #7 <signal handler called> #8 in gbm_bo_destroy (bo=0x0) at ../src/gbm/main/gbm.c:439 #9 in xwl_glamor_gbm_create_pixmap () at xwayland-glamor-gbm.c:245 #10 in ProcCreatePixmap () at dispatch.c:1440 #11 in Dispatch () at dispatch.c:478 #12 in dix_main () at main.c:276 To avoid the crash, only free the GBM bo if not `NULL`. Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Bugzilla: https://bugzilla.redhat.com/1729925
-
Adam Jackson authored
"bool" conflicts with C++ (meh) and stdbool.h (ngh alright fine). This is a driver-visible change and will likely break the build for mach64, but it can be fixed by simply using xf86ReturnOptValBool like every other driver. Signed-off-by:
Adam Jackson <ajax@redhat.com>
-
- 22 Jul, 2019 1 commit
-
-
Paolo Borelli authored
-
- 21 Jul, 2019 6 commits
-
-
Jon Turney authored
(Temporarily) drop building Xorg server (since this doesn't work after a530b6e8) until we come up with a better solution. (See #692)
-
Jon Turney authored
Run Cygwin's setup a second time to workaround for it's defective handling of obsolete packages. (Specifically, python3-lxml is currently obsoleted by python36-lxml, but that doesn't get installed on the first run)
-
Yaakov Selkowitz authored
mate-terminal apparently requires these to be present to work We just set them to describe one desktop, for the moment. It seems we can safely ignore the _NET_WM_DESKTOP property on child windows, and any _NET_WM_DESKTOP messages, as we only support one desktop for windows to be on. Signed-off-by:
Jon Turney <jon.turney@dronecode.org.uk>
-
Colin Harrison authored
-
Jon Turney authored
WM_WM_MAP was removed in 52e05b92 Rename WM_WM_MAP2 as WM_WM_MAP_UNMANAGED (meaning an override-redirect window, which manages it's own activation) Rename WM_WM_MAP3 as WM_WM_MAP_MANAGED (meaning a normal window, which is activated when clicked)
-
Jon Turney authored
Log a count of pixel formats which couldn't be used for various reasons
-
- 17 Jul, 2019 3 commits
-
-
Ignacio Casal Quinteiro authored
-
Ignacio Casal Quinteiro authored
-
Ignacio Casal Quinteiro authored
-
- 16 Jul, 2019 1 commit
-
-
Adam Jackson authored
There's not really a good way to query this from the wayland server, so just set the maximum to the X11 protocol limits. While we're at it, lower the minimum screen size to something implausibly small too, just in case. Fixes: xorg/xserver#850Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com>
-
- 15 Jul, 2019 1 commit
-
-
Olivier Fourdan authored
<sys/io.h> on ARM hasn't worked for a long, long time, so it was removed it from glibc upstream. Remove the include to avoid a compilation failure on ARM with glibc. Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Closes: xorg/xserver#840
-
- 12 Jul, 2019 1 commit
-
-
Olivier Fourdan authored
Running Xwayland non-rootless and resizing the output would lead to a crash while trying to update the larger areas of the root window. Make sure we resize the backing pixmap according to the new output size to avoid the crash. Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Closes: xorg/xserver#834Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com>
-
- 10 Jul, 2019 2 commits
-
-
Adam Jackson authored
Don't link against fb, it's the driver's responsibility to load that first. Underlinking like this is unpleasant but this matches what autotools does. Fixes: xorg/xserver#540
-
Matt Roper authored
Copied from Mesa with no modifications. This update brings in a significant number of new platform ID's. Syncs with mesa up to commit e334a595e ("intel/icl: Add new ICL PCI-IDs"). Signed-off-by:
Matt Roper <matthew.d.roper@intel.com>
-
- 03 Jul, 2019 1 commit
-
-
Michel Dänzer authored
This reverts commit ef91da27. I thought this couldn't work under any circumstances, but I was wrong, and drivers are already checking for cases that really cannot work. Fixes issue #839.
-
- 01 Jul, 2019 2 commits
-
-
Samuel Thibault authored
Since group_info and width are used for the key actions allocations, when modifying them we need to take care of reallocation key actions if needed.
-
Samuel Thibault authored
Some devices may not have keyboard information. Fixes #574
-
- 28 Jun, 2019 5 commits
-
-
Jon Turney authored
Set a linear gamma ramp. This avoids the xrandr command always warning 'Failed to get size of gamma for output default' (perhaps we should be using GDI GetDeviceGammaRamp(), if possible?) Make CRTC report non-zero physical dimensions initially
-
Jon Turney authored
The rrGetInfo hook is not called for all RANDR requests (e.g. RRGetOutputInfo), so we must always keep the fake mode information up to date, rather than doing it lazily in the rrGetInfo hook) Because we are so bad, most GTK+3 versions treat the output name 'default' specially, and don't try to use RANDR with it. But versions 3.21.6 to 3.22.24, don't do this, and get badly confused by a CRTC with size 0x0. See: https://bugzilla.gnome.org/show_bug.cgi?id=771033 https://bugzilla.gnome.org/show_bug.cgi?id=780101 Future work: Rather than reporting a single fake CRTC with a mode matching the entire virtual display, the fake CRTCs we report should match our 'pseudo-xinerama' monitors
-
Jon Turney authored
Make QueryMonitor() slightly less insane, making it return TRUE if the specified monitor exists, rather than always returning TRUE (which we are uselessly checking, and then also checking if the specified monitor exists) (Note that EnumDisplayMonitors() doesn't seem to have meaningful way to return errors, see 5940580f) Also: Spamming the long UseMsg() after "Invalid monitor number" isn't very helpful. Also: If we are exiting in ddxProcessArgument() due to an error in options, use a non-zero exit status.
-
Jon Turney authored
-
Colin Harrison authored
-