1. 23 Sep, 2019 2 commits
  2. 22 Sep, 2019 1 commit
    • Icenowy Zheng's avatar
      lima: fix PLBU viewport configuration · 8278b236
      Icenowy Zheng authored
      The PLBU expects the viewport's 4 borders' coordinates, however
      currently we're feeding the coordinate of the left-bottom point and the
      size to it, which leads to misrendering when the left-bottom point is
      not (0,0).
      
      Change the macros for the viewport PLBU command, and the data feed to
      it. The code to calculate the 4 borders is ported from Panfrost.
      Signed-off-by: Icenowy Zheng's avatarIcenowy Zheng <icenowy@aosc.io>
      Reviewed-by: Qiang Yu's avatarQiang Yu <yuq825@gmail.com>
      8278b236
  3. 21 Sep, 2019 13 commits
  4. 20 Sep, 2019 18 commits
  5. 19 Sep, 2019 6 commits
    • Ian Romanick's avatar
      nir/algebraic: Additional D3D Boolean optimization · 317a88b9
      Ian Romanick authored
      I observed this pattern in several shaders in Hand of Fate 2 while
      investigating bugzilla #111490.  This also led to the related
      bugzilla #111578.  The shaders from HoF2 are *not* in shader-db.
      Reviewed-by: Kenneth Graunke's avatarKenneth Graunke <kenneth@whitecape.org>
      
      Skylake and Ice Lake had similar results. (Ice Lake shown)
      total instructions in shared programs: 16222621 -> 16205419 (-0.11%)
      instructions in affected programs: 798418 -> 781216 (-2.15%)
      helped: 548
      HURT: 0
      helped stats (abs) min: 2 max: 158 x̄: 31.39 x̃: 35
      helped stats (rel) min: 0.45% max: 28.64% x̄: 2.83% x̃: 2.09%
      95% mean confidence interval for instructions value: -33.22 -29.56
      95% mean confidence interval for instructions %-change: -3.11% -2.56%
      Instructions are helped.
      
      total cycles in shared programs: 364676209 -> 363345763 (-0.36%)
      cycles in affected programs: 112810504 -> 111480058 (-1.18%)
      helped: 546
      HURT: 7
      helped stats (abs) min: 2 max: 118913 x̄: 2439.77 x̃: 2340
      helped stats (rel) min: 0.08% max: 37.56% x̄: 1.46% x̃: 1.08%
      HURT stats (abs)   min: 2 max: 770 x̄: 238.00 x̃: 43
      HURT stats (rel)   min: 0.02% max: 11.24% x̄: 3.71% x̃: 0.35%
      95% mean confidence interval for cycles value: -2884.33 -1927.41
      95% mean confidence interval for cycles %-change: -1.59% -1.21%
      Cycles are helped.
      
      total spills in shared programs: 8870 -> 8514 (-4.01%)
      spills in affected programs: 1230 -> 874 (-28.94%)
      helped: 161
      HURT: 0
      
      total fills in shared programs: 21901 -> 21348 (-2.52%)
      fills in affected programs: 2120 -> 1567 (-26.08%)
      helped: 155
      HURT: 5
      
      Broadwell and Haswell had similar results. (Broadwell shown)
      total instructions in shared programs: 14994910 -> 14975495 (-0.13%)
      instructions in affected programs: 839033 -> 819618 (-2.31%)
      helped: 548
      HURT: 0
      helped stats (abs) min: 2 max: 299 x̄: 35.43 x̃: 49
      helped stats (rel) min: 0.39% max: 19.89% x̄: 2.91% x̃: 2.22%
      95% mean confidence interval for instructions value: -37.46 -33.40
      95% mean confidence interval for instructions %-change: -3.12% -2.70%
      Instructions are helped.
      
      total cycles in shared programs: 386032453 -> 384450722 (-0.41%)
      cycles in affected programs: 117807357 -> 116225626 (-1.34%)
      helped: 547
      HURT: 6
      helped stats (abs) min: 2 max: 22096 x̄: 2892.01 x̃: 3926
      helped stats (rel) min: 0.17% max: 10.34% x̄: 1.56% x̃: 1.31%
      HURT stats (abs)   min: 4 max: 60 x̄: 32.83 x̃: 29
      HURT stats (rel)   min: 0.38% max: 12.79% x̄: 5.86% x̃: 4.65%
      95% mean confidence interval for cycles value: -3060.28 -2660.27
      95% mean confidence interval for cycles %-change: -1.59% -1.37%
      Cycles are helped.
      
      total spills in shared programs: 23372 -> 21869 (-6.43%)
      spills in affected programs: 11730 -> 10227 (-12.81%)
      helped: 352
      HURT: 0
      
      total fills in shared programs: 34747 -> 35351 (1.74%)
      fills in affected programs: 11013 -> 11617 (5.48%)
      helped: 3
      HURT: 347
      
      Ivy Bridge and Sandybridge had similar results. (Ivy Bridge shown)
      total instructions in shared programs: 11956420 -> 11956126 (<.01%)
      instructions in affected programs: 14898 -> 14604 (-1.97%)
      helped: 98
      HURT: 0
      helped stats (abs) min: 3 max: 3 x̄: 3.00 x̃: 3
      helped stats (rel) min: 1.30% max: 3.57% x̄: 2.08% x̃: 2.00%
      95% mean confidence interval for instructions value: -3.00 -3.00
      95% mean confidence interval for instructions %-change: -2.18% -1.98%
      Instructions are helped.
      
      total cycles in shared programs: 178791217 -> 178790792 (<.01%)
      cycles in affected programs: 149763 -> 149338 (-0.28%)
      helped: 91
      HURT: 7
      helped stats (abs) min: 3 max: 107 x̄: 20.63 x̃: 16
      helped stats (rel) min: 0.13% max: 6.91% x̄: 1.40% x̃: 1.18%
      HURT stats (abs)   min: 3 max: 322 x̄: 207.43 x̃: 322
      HURT stats (rel)   min: 0.14% max: 19.85% x̄: 12.73% x̃: 17.41%
      95% mean confidence interval for cycles value: -18.94 10.27
      95% mean confidence interval for cycles %-change: -1.28% 0.49%
      Inconclusive result (value mean confidence interval includes 0).
      317a88b9
    • Ian Romanick's avatar
      nir/algebraic: Do not apply late DPH optimization in vertex processing stages · 92f70df8
      Ian Romanick authored
      Some shaders do not use 'invariant' in vertex and (possibly) geometry
      shader stages on some outputs that are intended to be invariant.  For
      various reasons, this optimization may not be fully applied in all
      shaders used for different rendering passes of the same geometry.  This
      can result in Z-fighting artifacts (at best).  For now, disable this
      optimization in these stages.
      
      In tessellation stages applications seem to use 'precise' when
      necessary, so allow the optimization in those stages.
      Reviewed-by: Kenneth Graunke's avatarKenneth Graunke <kenneth@whitecape.org>
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111490
      Fixes: 09705747 ("nir/algebraic: Reassociate fadd into fmul in DPH-like pattern")
      
      All Gen8+ platforms had similar results. (Ice Lake shown)
      total instructions in shared programs: 16194726 -> 16344745 (0.93%)
      instructions in affected programs: 2855172 -> 3005191 (5.25%)
      helped: 6
      HURT: 20279
      helped stats (abs) min: 1 max: 3 x̄: 1.33 x̃: 1
      helped stats (rel) min: 0.44% max: 1.00% x̄: 0.54% x̃: 0.44%
      HURT stats (abs)   min: 1 max: 32 x̄: 7.40 x̃: 7
      HURT stats (rel)   min: 0.14% max: 42.86% x̄: 8.58% x̃: 6.56%
      95% mean confidence interval for instructions value: 7.34 7.45
      95% mean confidence interval for instructions %-change: 8.48% 8.67%
      Instructions are HURT.
      
      total cycles in shared programs: 364471296 -> 365014683 (0.15%)
      cycles in affected programs: 32421530 -> 32964917 (1.68%)
      helped: 2925
      HURT: 16144
      helped stats (abs) min: 1 max: 403 x̄: 18.39 x̃: 5
      helped stats (rel) min: <.01% max: 22.61% x̄: 1.97% x̃: 1.15%
      HURT stats (abs)   min: 1 max: 18471 x̄: 36.99 x̃: 15
      HURT stats (rel)   min: 0.02% max: 52.58% x̄: 5.60% x̃: 3.87%
      95% mean confidence interval for cycles value: 21.58 35.41
      95% mean confidence interval for cycles %-change: 4.36% 4.52%
      Cycles are HURT.
      92f70df8
    • Andres Gomez's avatar
      docs/features: Update VK_KHR_display_swapchain status · bcd92247
      Andres Gomez authored
      It was set as done by mistake.
      
      Fixes: bc15d745 ("docs/features: Mark some Vulkan extensions as done")
      Signed-off-by: Andres Gomez's avatarAndres Gomez <agomez@igalia.com>
      Acked-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
      Reviewed-by: Bas Nieuwenhuizen's avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      bcd92247
    • Andres Gomez's avatar
      docs/features: Update status list of Vulkan extensions · 53c24cfd
      Andres Gomez authored
      To get the extension list:
      
      $ git grep -hE "extension name=\"VK_KHR" src/vulkan/registry/vk.xml | \
      grep -v disabled | awk '{print $2}' | sed -E 's/(name=)?"//g' | sort
      
      To find anv(il) and radv supported extensions:
      
      $ git grep -hE "'VK_([A-Z]+)_[a-z,0-9]" src/intel/
      
      $ git grep -hE "'VK_([A-Z]+)_[a-z,0-9]" src/amd/
      
      v2:
        - Keep VK_KHR_device_group and VK_KHR_device_group_creation as not
          started (Jason).
      Signed-off-by: Andres Gomez's avatarAndres Gomez <agomez@igalia.com>
      Acked-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
      Reviewed-by: Bas Nieuwenhuizen's avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      53c24cfd
    • Jason Ekstrand's avatar
      Move blob from compiler/ to util/ · 0c4e89ad
      Jason Ekstrand authored
      There's nothing whatsoever compiler-specific about it other than that's
      currently where it's used.
      Reviewed-by: Kristian H. Kristensen's avatarKristian H. Kristensen <hoegsberg@google.com>
      Reviewed-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      0c4e89ad
    • Boris Brezillon's avatar
      Revert "panfrost: Rework midgard_pair_load_store() to kill the nested foreach loop" · fc5a8771
      Boris Brezillon authored
      There's a missing prev_ldst = NULL; assignment in the new logic,
      but even with this fixed it seems to regress some applications,
      so let's revert the change until we find the real problem.
      
      This reverts commit c9bebae2.
      fc5a8771