From 2b4798ce56afc1d90bcc4be4c9c874588abdbcd7 Mon Sep 17 00:00:00 2001
From: Lyude Paul <lyude@redhat.com>
Date: Thu, 23 May 2024 16:52:01 -0400
Subject: [PATCH] WIP: rust: drm/kms: Add RawPlaneState::atomic_helper_check()
Add a binding for drm_atomic_helper_check_plane_state(). Since we want to
make sure that the user is passing in the new state for a Crtc instead of
an old state, we explicitly ask for a reference to a BorrowedCrtcState.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
TODO:
* Add support for scaling options
---
rust/kernel/drm/kms/plane.rs | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/rust/kernel/drm/kms/plane.rs b/rust/kernel/drm/kms/plane.rs
index 4d542963da881..0e7ee44e9f124 100644
--- a/rust/kernel/drm/kms/plane.rs
+++ b/rust/kernel/drm/kms/plane.rs
@@ -618,6 +618,33 @@ pub trait RawPlaneState: AsRawPlaneState {
// SAFETY: This cast is guaranteed safe by `OpaqueCrtc`s invariants.
NonNull::new(self.as_raw().crtc).map(|c| unsafe { OpaqueCrtc::from_raw(c.as_ptr()) })
}
+
+ /// Run the atomic check helper for this plane and the given CRTC state.
+ fn atomic_helper_check<S, D>(
+ &mut self,
+ crtc_state: &CrtcStateMutator<'_, S>,
+ can_position: bool,
+ can_update_disabled: bool
+ ) -> Result
+ where
+ D: KmsDriver,
+ S: FromRawCrtcState,
+ S::Crtc: ModesettableCrtc + ModeObject<Driver = D>,
+ Self::Plane: ModeObject<Driver = D>,
+ {
+ // SAFETY: We're passing the mutable reference from `self.as_raw_mut()` directly to DRM,
+ // which is safe.
+ to_result(unsafe {
+ bindings::drm_atomic_helper_check_plane_state(
+ self.as_raw_mut(),
+ crtc_state.as_raw(),
+ bindings::DRM_PLANE_NO_SCALING as _, // TODO: add parameters for scaling
+ bindings::DRM_PLANE_NO_SCALING as _,
+ can_position,
+ can_update_disabled
+ )
+ })
+ }
}
impl<T: AsRawPlaneState + ?Sized> RawPlaneState for T {}
--
GitLab