Commit 43dba6ce authored by Edward Hervey's avatar Edward Hervey 🤘

miniobjects: Don't chain up to empty finalize method.

If ever we do anything in mini_object_finalize, we should make sure the 4
core miniobject finalize methods chain back up again.
parent 5d819bef
......@@ -165,8 +165,8 @@ gst_buffer_finalize (GstBuffer * buffer)
gst_caps_replace (&GST_BUFFER_CAPS (buffer), NULL);
((GstMiniObjectClass *)
gst_buffer_parent_class)->finalize (GST_MINI_OBJECT_CAST (buffer));
/* ((GstMiniObjectClass *) */
/* gst_buffer_parent_class)->finalize (GST_MINI_OBJECT_CAST (buffer)); */
}
/**
......
......@@ -231,7 +231,7 @@ gst_event_finalize (GstEvent * event)
gst_structure_free (event->structure);
}
GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (event));
/* GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (event)); */
}
static GstEvent *
......
......@@ -207,7 +207,7 @@ gst_message_finalize (GstMessage * message)
gst_structure_free (message->structure);
}
GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (message));
/* GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (message)); */
}
static GstMessage *
......
......@@ -159,6 +159,14 @@ static void
gst_mini_object_finalize (GstMiniObject * obj)
{
/* do nothing */
/* WARNING: if anything is ever put in this method, make sure that the
* following sub-classes' finalize method chains up to this one:
* gstbuffer
* gstevent
* gstmessage
* gstquery
*/
}
/**
......
......@@ -191,7 +191,7 @@ gst_query_finalize (GstQuery * query)
gst_structure_free (query->structure);
}
GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (query));
/* GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (query)); */
}
static GstQuery *
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment