Skip to content
  • Wim Taymans's avatar
    bin: reorganize _remove_func to avoid races · 85d5a29b
    Wim Taymans authored
    Make the gst_bin_remove_func more like the add_func. Check if the element we try
    to remove from the bin has the bin as the parent and set the parent flag to NULL
    immediately, this allows us to avoid concurrent remove operations without using
    the UNPARENTING element flag. After we unparented the element from the bin, we
    update the bin state and remove the element from the list. Finally we unlink
    all the pads.
    
    This avoids a race condition where the element could still claim to have the
    bin as the parent while the bin didn't have a pointer to the element anymore.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=647759
    85d5a29b