1. 20 Apr, 2019 1 commit
    • Thomas Haller's avatar
      gitlab-ci: install glib2-doc via "contrib/fedora/REQUIRED_PACKAGES" · f43fb59b
      Thomas Haller authored
      We also generate a source tarball and artifact it.
      
      Hence, we need proper gtk-doc links. This requires files in
      /usr/share/gtk-doc/html for adding cross links. Install glib2-doc
      package.
      
      Note that in containers dnf is configured to not install documentation
      files. We need to override that.
      
      (cherry picked from commit a0f31e40)
      f43fb59b
  2. 19 Apr, 2019 1 commit
  3. 18 Apr, 2019 1 commit
  4. 11 Apr, 2019 1 commit
  5. 09 Apr, 2019 3 commits
  6. 07 Apr, 2019 1 commit
    • Thomas Haller's avatar
      gitlab-ci: run unit tests for n-acd with eBPF disabled · a5869d1b
      Thomas Haller authored
      Enabling eBPF causes src/devices/tests/test-acd to fail:
      
          strace: bpf(BPF_MAP_CREATE, {map_type=BPF_MAP_TYPE_HASH, key_size=4, value_size=1, max_entries=8, map_flags=0, inner_map_fd=0, map_name="", map_ifindex=0, btf_fd=0, btf_key_type_id=0, btf_value_type_id=0}, 112) = -1 EPERM (Operation not permitted)
      
          NetworkManager-Message: 10:07:04.404: <warn>  [1554631624.4046] acd[0xa2b400,10]: couldn't init ACD for announcing addresses on interface 'nm-test-veth0': Operation not permitted
      
      Interestingly it does not always fail. Seems to depend on the kernel
      which is used in the containerized test environments of gitlab-ci.
      
      For now, just disable eBPF and use the fallback implementation.
      a5869d1b
  7. 04 Apr, 2019 1 commit
    • Thomas Haller's avatar
      contrib/rpm: disable NDEBUG for meson builds · ef338667
      Thomas Haller authored
      For better or worse, our release builds commonly do not disable assertions.
      That means,
      
       - NDEBUG is not set, and assert() is in effect
       - G_DISABLE_ASSERT is not set, and g_assert() is in effect
       - G_DISABLE_CHECKS is not set, and g_return*() is in effect.
      
      On the other hand, NM_MORE_ASSERTS is not enabled by default and nm_assert()
      is stripped away. That is the actual purpose of nm_assert(): it is
      commonly disabled on release builds, while all other assertions are
      enabled.
      
      Note that it is fully supported to build NetworkManager with all kind of
      assertions disabled. However, such a configuration is not much tested
      and I would not recommend it for that reason.
      
      %meson expands to
      
        $ /usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled -Db_ndebug=true . x86_64-redhat-linux-gnu $OTHER_ARGS
      
      thus passing -DNDEBUG to the meson build. Override that.
      ef338667
  8. 03 Apr, 2019 1 commit
  9. 20 Mar, 2019 1 commit
  10. 19 Mar, 2019 1 commit
    • Lubomir Rintel's avatar
      all: goodbye libnm-glib · 1de8383a
      Lubomir Rintel authored
      This removes libnm-glib, libnm-glib-vpn, and libnm-util for good.
      The it has been replaced with libnm since NetworkManager 1.0, disabled
      by default since 1.12 and no up-to-date distributions ship it for years
      now.
      
      Removing the libraries allows us to:
      
      * Remove the horrible hacks that were in place to deal with accidental use
        of both the new and old library in a single process.
      * Relief the translators of maintenance burden of similar yet different
        strings.
      * Get rid of known bad code without chances of ever getting fixed
        (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c)
      * Generally lower the footprint of the releases and our workspace
      
      If there are some really really legacy users; they can just build
      libnm-glib and friends from the NetworkManager-1.16 distribution. The
      D-Bus API is stable and old libnm-glib will keep working forever.
      
      https://github.com/NetworkManager/NetworkManager/pull/308
      1de8383a
  11. 18 Mar, 2019 1 commit
    • Thomas Haller's avatar
      contrib/checkpatch: avoid command injection in checkpatch.pl script · d66a1ace
      Thomas Haller authored
      The capture variables, $1, etc, are not valid unless the match
      succeeded, and they're not cleared, either.
      
          $ git checkout -B C origin/master && \
              echo XXXXX > f.txt && \
              git add f.txt && \
              git commit -m 'this commit does something()'
          Branch 'C' set up to track remote branch 'master' from 'origin'.
          Reset branch 'C'
          Your branch is up to date with 'origin/master'.
          sh: -c: line 0: syntax error near unexpected token `('
          sh: -c: line 0: `git log --abbrev=12 --pretty=format:"%h ('%s')" -1 does something() 2>/dev/null'
      
          >>> VALIDATE "a169a98e14 this commit does something()"
          (commit message):4: Commit 'does something()' does not seem to exist:
          > Subject: [PATCH] this commit does something()
      
          (commit message):4: Refer to the commit id properly: :
          > Subject: [PATCH] this commit does something()
      
          The patch does not validate.
      d66a1ace
  12. 13 Mar, 2019 2 commits
  13. 07 Mar, 2019 18 commits
  14. 08 Feb, 2019 3 commits
  15. 07 Feb, 2019 4 commits