Skip to content
  • Lubomir Rintel's avatar
    core: separate active and applied connection · 06da3532
    Lubomir Rintel authored and Thomas Haller's avatar Thomas Haller committed
    
    
    Clone the connection upon activation. This makes it safe for the user
    to modify the original connection while it is activated.
    
    This involves several changes:
    
    - NMActiveConnection gets @settings_connection and @applied_connection.
      To support add-and-activate, we constructing a NMActiveConnection with
      no connection set. Previously, we would set the "connection" field to
      a temporary NMConnection. Now NMManager piggybacks this temporary
      connection as object-data (TAG_ACTIVE_CONNETION_ADD_AND_ACTIVATE).
    
    - get rid of the functions nm_active_connection_get_connection_type()
      and nm_active_connection_get_connection_uuid(). From their names
      it is unclear whether this returns the settings or applied connection.
      The (few) callers should figure that out themselves.
    
    - rename nm_active_connection_get_id() to
      nm_active_connection_get_settings_connection_id(). This function
      is only used internally for logging.
    
    - dispatcher calls now get two connections as well. The
      applied-connection is used for the connection data, while
      the settings-connection is used for the connection path.
    
    - needs special handling for properties that apply immediately
      when changed (nm_device_reapply_settings_immediately()).
    
    Co-Authored-By: default avatarThomas Haller <thaller@redhat.com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724041
    06da3532