libnice issueshttps://gitlab.freedesktop.org/libnice/libnice/-/issues2020-10-06T11:46:50Zhttps://gitlab.freedesktop.org/libnice/libnice/-/issues/101drop old nice compatibility modes ?2020-10-06T11:46:50ZFabrice Belletfabrice@bellet.infodrop old nice compatibility modes ?What about the removal of old nice compatibilities modes ?
in ``agent.h``, we have:
```
typedef enum
{
NICE_COMPATIBILITY_RFC5245 = 0,
NICE_COMPATIBILITY_DRAFT19 = NICE_COMPATIBILITY_RFC5245,
NICE_COMPATIBILITY_GOOGLE,
NICE_COMP...What about the removal of old nice compatibilities modes ?
in ``agent.h``, we have:
```
typedef enum
{
NICE_COMPATIBILITY_RFC5245 = 0,
NICE_COMPATIBILITY_DRAFT19 = NICE_COMPATIBILITY_RFC5245,
NICE_COMPATIBILITY_GOOGLE,
NICE_COMPATIBILITY_MSN,
NICE_COMPATIBILITY_WLM2009,
NICE_COMPATIBILITY_OC2007,
NICE_COMPATIBILITY_OC2007R2,
NICE_COMPATIBILITY_LAST = NICE_COMPATIBILITY_OC2007R2,
} NiceCompatibility;
```
* for example, is it still useful to continue to maintain everything except NICE_COMPATIBILITY_RFC5245 and NICE_COMPATIBILITY_OC2007R2? ``conncheck.c`` for example, contains several code paths and code logic for these other modes, that are difficult if not possible to test, outside the test-suite. As we make more changes without the possibility to test the legacy modes in real world, the risks are great that we just break them silently.
* What consequence would have a nice compatibility modes clean up on stun compatibility modes ?https://gitlab.freedesktop.org/libnice/libnice/-/issues/15libnice overly generic <agent.h>2020-11-18T14:53:13ZPhilip Withnalllibnice overly generic <agent.h>## Submitted by Philip Withnall `@pwithnall`
Assigned to **Philip Withnall `@pwithnall`**
**[Link to original bug (#113)](https://phabricator.freedesktop.org/T113)**
## Description
(Migrated from Bugzilla: https://bugs.freedesktop...## Submitted by Philip Withnall `@pwithnall`
Assigned to **Philip Withnall `@pwithnall`**
**[Link to original bug (#113)](https://phabricator.freedesktop.org/T113)**
## Description
(Migrated from Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90013)
libnice stores its headers in e.g. /usr/include/nice/ but 'pkg-config --cflags nice'
gives '-D_REENTRANT -I/usr/include/nice' meaning a generic-named header should as agent.h, debug.h or interfaces.h is includable as:
#include <agent.h>
#include <debug.h>
#include <interfaces.h>
Moreover, the include-guard used in e.g. agent.h:
#ifndef _AGENT_H
#define _AGENT_H
is overly generic as well, and risks collision with other packages.https://gitlab.freedesktop.org/libnice/libnice/-/issues/5Fix socket function naming2021-12-06T09:16:13ZPhilip WithnallFix socket function naming## Submitted by Philip Withnall `@pwithnall`
Assigned to **Philip Withnall `@pwithnall`**
**[Link to original bug (#98)](https://phabricator.freedesktop.org/T98)**
## Description
(Migrated from Bugzilla: https://bugs.freedesktop.o...## Submitted by Philip Withnall `@pwithnall`
Assigned to **Philip Withnall `@pwithnall`**
**[Link to original bug (#98)](https://phabricator.freedesktop.org/T98)**
## Description
(Migrated from Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75598)
nice_agent_send() is non-blocking, but nice_agent_recv() is blocking. The naming somehow needs to be reconciled.