Renomination check broken?
I was experimenting with forcing renomination like behavior in release 0.1.16, and noticed that the local_candidate and remote_candidate arguments appeared to be swapped in
conn_check_handle_renomination. It is also still like this in master.
At decleration, concheck.c:3956
static gboolean conn_check_handle_renomination (NiceAgent *agent, NiceStream *stream, NiceComponent *component, StunMessage *req, NiceCandidate *remote_candidate, NiceCandidate *local_candidate)
At invocation, concheck.c:4377
conn_check_handle_renomination(agent, stream, component, &req, local_candidate, remote_candidate);
I currently do not have a setup to test proper renomination, but this code path does not seem to work unless I manually swap the arguments.