GitLab

Livio Madaro authored Feb 29, 2012 and Youness Alaoui committed Mar 01, 2012

Use GSocket for better Windows compatibility

Should use the remote priority rather than the priority of the parent pair
Thanks to Filippo Della Betta

Filippo Della Betta authored Feb 15, 2012 and Youness Alaoui committed Feb 15, 2012

Since Visual Studio compiler does not support C99 I put some declarations
at the beginning of the statement.

Filippo Della Betta authored Feb 15, 2012 and Youness Alaoui committed Feb 15, 2012

Included the replacement header win32_common.h instead of the missing header stdint.h on WIN32 platform

Filippo Della Betta authored Feb 15, 2012 and Youness Alaoui committed Feb 15, 2012

As glib documentation suggests (http://developer.gnome.org/glib/2.28/glib-IO-Channels.html),
g_io_channel_unix_new should be avoided on WIN32 platform.
Replaced with g_io_channel_win32_new_socket function

If using a proxy, the 'from' of all packets were of the proxy server
instead of the turn server, causing the check for turn to fail.
Thanks to Madaro Livio.

Madaro Livio authored Feb 13, 2012 and Youness Alaoui committed Feb 13, 2012

I have a use case where len < 0 but the socket is still working.
It is when the stun server is not listening and the client receives
ICMP messages. I think it is a Windows specific problem.
Calling WSAGetLastError() returns WSAECONNRESET.
The MSDN documentation sais:
"On a UDP-datagram socket, this error would indicate that a previous
send operation resulted in an ICMP "Port Unreachable" message."
http://msdn.microsoft.com/en-us/library/windows/desktop/ms740121(v=vs.85).aspx

Madaro Livio authored Feb 10, 2012 and Youness Alaoui committed Feb 10, 2012

If TURN server is not listening then nice_tcp_bsd_socket_new
returns socket=NULL and libnice crashes.

Conflicts:
	configure.ac

Madaro Livio authored Feb 08, 2012 and Youness Alaoui committed Feb 08, 2012

Calling nice_agent_remove_stream will try to release the TURN allocation (lifetime=0)
but it won't work because the CandidateRefresh doesn't contain credentials
for user authentication (if it happens right after the allocation).
The server replies with an authentication error but the client closed the socket
and does not reply to it.

Madaro Livio authored Feb 08, 2012 and Youness Alaoui committed Feb 08, 2012

not valid if the socket is reliable (TCP).
The patch does not add the candidate to the local candidate list
if the socket is reliable.

Madaro Livio authored Feb 08, 2012 and Youness Alaoui committed Feb 08, 2012

If a client connects to a TURN server using a reliable socket (TCP)
then retransmission of TURN messages (allocation request) is not needed.
Libnice 0.1.1 retransmit the TURN messages (allocation request) in the
same way for reliable (TCP) and not reliable (UDP) socket.

Madaro Livio authored Feb 08, 2012 and Youness Alaoui committed Feb 08, 2012

Data padding is required for interoperability with standard TURN server.

Mark pair as nominated when it's a remote peer-reflexive candidate discovered through an early incoming check which has use-candidate