1. 17 Feb, 2020 1 commit
  2. 14 Feb, 2020 2 commits
    • Jakub Adam's avatar
      conncheck: Connection check reply must have a remote candidate · 502ddb83
      Jakub Adam authored
      Ensure that a conncheck reply is coming from an address and port of a
      known remote candidate and that the type of incoming socket matches that
      candidate's transport.
      
      Attemps to fix a Coverity issue in which no matching remote_candidate
      gets found for a connectivity reply in conn_check_handle_inbound_stun()
      (apparently due to transport mismatch), yet
      priv_map_reply_to_conn_check_request() still successfully matches it
      with a previous request.
      502ddb83
    • Jakub Adam's avatar
      conncheck: Typo fix · 7af761f3
      Jakub Adam authored
      7af761f3
  3. 13 Feb, 2020 9 commits
  4. 11 Feb, 2020 4 commits
    • Fabrice Bellet's avatar
      30d592e8
    • Fabrice Bellet's avatar
      agent: update the selected pair priority when foundation changes · dec008ca
      Fabrice Bellet authored
      The component selected pair priority may have its priority modified
      if the foundation of its remote candidate changes. This update needs
      to be recorded, even if its not signalled, since this value is used
      in the conncheck in priv_update_selected_pair().
      dec008ca
    • Fabrice Bellet's avatar
      a0b48d44
    • Fabrice Bellet's avatar
      agent: verify the best nominated pair after priorities recalculation · 8a3e8c76
      Fabrice Bellet authored
      When we get a set_remote_candidate late after the start of the
      conncheck, some remote candidates type may change from peer-reflexive
      to server-reflexive. This required a recalculation of the foundations
      and of the priorities of the related pairs.
      
      This recalculation may change the pairs ordering in the conncheck list:
      a srflx:prflx pair becoming a srflx:srflx pair will have a lower
      priority (RFC 8445, section 5.1.2.1 "Recommended Formula", "the type
      preference for peer-reflexive candidates MUST be higher than that of
      server-reflexive candidates.")
      
      This recalculation is required to maintain the same pairs ordering in
      both agent.
      
      But in some cases, in aggressive nomination mode, this may also change
      the selected pair, if this recalculation changed the highest priority
      pair with the nominated flag.
      8a3e8c76
  5. 10 Feb, 2020 5 commits
  6. 06 Feb, 2020 9 commits
  7. 05 Feb, 2020 2 commits
  8. 17 Dec, 2019 1 commit
    • Xavier Claessens's avatar
      Fix building doc when libnice is a subproject · d4ef6b69
      Xavier Claessens authored
      When passing strings to 'src_dir', they are assumed to be relative to
      the root source dir of main project. That's possibly a Meson bug, it
      should be relative to current source dir. In any case, it's better to
      use include_directories() to avoid any confusion.
      d4ef6b69
  9. 11 Dec, 2019 1 commit
  10. 06 Dec, 2019 3 commits
  11. 26 Nov, 2019 1 commit
    • Jakub Adam's avatar
      conncheck: fix long time to connect if conncheck list gets filled late · da7acb34
      Jakub Adam authored
      When a stream's conncheck list is empty during
      priv_conn_check_unfreeze_related() and the check pairs get added only
      afterwards, the whole list may remain in frozen state for tens of
      seconds until the lists of all other streams are completed.
      
      If a connection check list missed the opportunity to be unfrozen
      according to the process in RFC 5245 Section 7.1.3.2.3 because it was
      empty at the time, unfreeze it immediately once some check pair gets
      added.
      da7acb34
  12. 17 Sep, 2019 1 commit
  13. 05 Aug, 2019 1 commit