Keyboard inhibition through tablet-mode and 2-in-1s
(Forwarded from https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/79)
It seems that keyboard inhibition through tablet-mode switch brought some unexpected issues in certain 2-in-1 models. On an Acer Switch Alpha 12 (a Surface knock-off) that features:
- Volume/Windows keys built in the tablet body. Device is seen as "AT Translated Set 2 keyboard", and announcing itself as a full blown keyboard o.
- A regular, detachable keyboard. Device is seen as "Chicony ACER Hawaii Keyboard", spread throughout 2 devices.
I see the former receiving the
"internal" keyboard integration flag, while the second doesn't. This brings 2 unexpected issues:
- When the actual keyboard is detached, the volume keys stop working.
- It's also potentially wrong the other way around, as tablet-mode may be also triggered without the keyboard being detached (eg. folding it behind the screen also triggers it).
The minimal work to do this right would just invert treatment of the
"internal" flag through quirks. However the naming of the flag gets kind of funny when you think of it :), now we have an "AT keyboard" that physically is internal but shouldn't get disabled, and an "internal" device that can be torn. Perhaps there should be other more descriptive flags for this?
"internal-detachable" come to mind, or maybe a more unequivocal