1. 28 Aug, 2018 2 commits
    • Peter Hutterer's avatar
      test: drop the sleep_ms argument · 7768d7d9
      Peter Hutterer authored
      This forces events for every ~10ms now. If we want a slower movement, we need
      more steps - just like a real touchpad does it.
      
      Cocinelle spatch files were variants of:
      	@@
      	expression A, B, C, D, E, F, G, H, I, J, K;
      	@@
      
      	- litest_touch_move_two_touches(A, B, C, D, E, F, G, H, I)
      	+ litest_touch_move_two_touches(A, B, C, D, E, F, G, H)
      
      The only test that needed a real fix was touchpad_no_palm_detect_2fg_scroll,
      it used 12ms before, now it's using 10ms so on the bcm5974 touchpad the second
      finger was a speed-thumb. Increasing the events and thus slowing down the
      pointer means it's a normal finger and the test succeeds again.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      7768d7d9
    • Peter Hutterer's avatar
      test: change a few tests to use 10ms intervals · bdc7ef8b
      Peter Hutterer authored
      Change a number of tests to use 10ms intervals between finger events and fix
      the coordinates up accordingly to avoid pointer jumps. This is in preparation
      for a test-suite wide use of 10ms intervals.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      bdc7ef8b
  2. 13 Aug, 2018 1 commit
    • Peter Hutterer's avatar
      touchpad: if a finger in the button area moves by more than 5mm, release it · 13bda5ad
      Peter Hutterer authored
      The software button area is currently a partially-dead area. If the finger
      moves into or out of the area pointer motion works. Finger motion within the
      area however does not generate motion.
      
      The main motivation for this was to avoid accidental pointer motion when a
      button is pressed. This is required for stationary fingers but once you move a
      significant distance, those bets are off.
      
      So if the finger moves by more than 5mm from where it was put down, release it
      and let it move the pointer.
      
      The full impact is largely limited to horizontal movements within the button
      area because:
      - leaving the finger at the bottom area for 300ms without movement triggers
        the thumb identification, so it won't move anyway.
      - moving the finger north is likely to go off the button area before we
        trigger this threshold.
      
      libinput/libinput#86Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      13bda5ad
  3. 19 Apr, 2018 1 commit
  4. 23 Mar, 2018 1 commit
  5. 20 Nov, 2017 1 commit
  6. 19 Nov, 2017 1 commit
  7. 04 Jul, 2017 1 commit
    • Peter Hutterer's avatar
      touchpad: send a left button event when we move out of topbuttons and click · d698de6e
      Peter Hutterer authored
      We used to completely ignore a finger that was within the top software button
      area and then moved to the main area and remained there for a timeout. This
      avoids erroneous pointer movements when the user moves the finger while using
      the trackpoint.
      
      But we also ignored physical clicks, something we should not be doing. This
      patch fixes that behavior: we still ignore the finger for movement, but a
      physical click now triggers a left click once we've been in the area for the
      timeout.
      
      This new behavior doesn't apply within the timeout, i.e. if a finger is in the
      right top button area, moves out and immediately clicks, we still trigger a
      right click. This avoids erroneous switches to left-clicks when the finger is
      at the edge of the button area and moves out during the press.
      
      Related to: https://bugs.freedesktop.org/show_bug.cgi?id=99212Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      d698de6e
  8. 01 Mar, 2017 1 commit
  9. 08 Feb, 2017 1 commit
  10. 06 Feb, 2017 1 commit
  11. 15 Jan, 2017 1 commit
  12. 02 Aug, 2016 1 commit
  13. 03 Jul, 2016 1 commit
  14. 05 Apr, 2016 1 commit
    • Peter Hutterer's avatar
      touchpad: add a middle button software area · 886b5a2c
      Peter Hutterer authored
      Middle button interaction is most commonly to paste and it is a single-event
      interaction (button press). We provided middle button in software button mode
      by emulating it with a two-finger press with L+R down at the same time. This
      is also what many touchpads are spectacularly bad at, it is very common to
      detect the physical button down event before the second finger registers,
      resulting in left or right clicks where a middle button should be triggered.
      
      Unless the fingers are resting on the touchpad for at least one scanout, the
      success rate for middle button emulation is only at 70% or so.
      
      This patch adds a 25%-width middle button area between the left and the right
      software button, everything else stays the same. To avoid immediate breakage,
      the middle button emulation remains but may be removed in the future.
      The doc is updated to only refer to the middle button area now.
      
      https://bugs.freedesktop.org/show_bug.cgi?id=94755Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: 's avatarHans de Goede <hdegoede@redhat.com>
      886b5a2c
  15. 30 Jul, 2015 1 commit
  16. 27 Jul, 2015 1 commit
  17. 23 Jul, 2015 1 commit