libinput_event_gesture_get_base_event does not work with LIBINPUT_EVENT_GESTURE_HOLD_BEGIN
Summary
Steps to reproduce
Calling libinput_event_gesture_get_base_event
with a struct libinput_event_gesture *
of type LIBINPUT_EVENT_GESTURE_HOLD_BEGIN
(and likely also LIBINPUT_EVENT_GESTURE_HOLD_END
) causes the following output:
libinput error: client bug: Invalid event type LIBINPUT_EVENT_GESTURE_HOLD_BEGIN (806) passed to libinput_event_gesture_get_base_event()
Required information
- libinput version: 1.19
- hardware information: irrelevant
Additional information
I discovered this behavior when updating my libinput rust bindings for version 1.19: https://github.com/Smithay/input.rs/issues/31
I have no found any other *get_base_event
function, that does accept GESTURE_HOLD_*
events looking at the source.
I appears to be an oversight that these new types were not added to libinput_event_gesture_get_base_event
.
If adding those two types to the function is all that should be needed to fix this issue, I will gladly make a merge request to fix this.