Clickpads register 3 fingers during 2-finger click for physical button press
Summary
Hello again! I haven't checked in for quite some time due to a job change, but I noticed a small issue with !292 (merged) after purchasing a new laptop and installing the OS from scratch. (Previously I'd had a custom libinput in /usr/local/bin so I had not noticed the change.)
This patch makes sense for taps, but causes a regression in behavior when using the physical button of a clickpad. As I see it (and as MacOS and I believe Windows do), the expected behavior when resting two fingers in the center of the touchpad, then using a thumb to physically press the clickpad down, should be a 2-finger click. But with this patch, it's usually registered as a 3-finger click instead unless the thumb is very far away from the fingers, both horizontally and vertically.
The ideal behavior would count the seeming "thumb" and register all touches in a tap, but aggressively discard any thumb touch in a physical clickpad button press.
I will take a closer look at this when I can. Given the state of the world at the moment, I might have some more time to work on it!
Steps to reproduce
Rest two fingers on the center of a "clickpad" touchpad. Use thumb to physically press the clickpad button.
Expected behavior: A two-finger click (usually right-click) is registered. Actual behavior: Unless the thumb is very far away in the far corner of the touchpad, a three-finger click is registered instead.
Required information
- libinput version: 1.15.4
- hardware information: Dell XPS 15 7590 and Dell XPS 15 9550