- 29 Jun, 2022 1 commit
-
-
Peter Hutterer authored
Loop variables shouldn't be re-used. Avoid uninitialized variables Sort variables to make function calls more obvious Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 28 Jun, 2022 3 commits
-
-
Peter Hutterer authored
We've long preferred GTK4 and that's installed on our images, so let's make sure that gets removed together with GTK3 (which isn't actually installed anyway). Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Introduced in 6a1bd5b0, we now have two potentially undeclared variables if GTK is available but doesn't have Wayland support. ../meson.build:576:1: ERROR: Unknown variable "dep_wayland_client". Fixes 6a1bd5b0 Fixes #786 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
satrmb authored
The `debounce_bounce_high_delay` and `debounce_spurious_trigger_high_delay` tests are failing with annoying frequency in valgrind, but that is entirely due to valgrind being too slow for the tight timing reqirements of these tests. Skipping them in valgrind has next to no potential to hide memory leaks because the code paths leading to success are also covered by other tests which are less picky about timing, and the CI test suite run without valgrind still tests for their success. Signed-off-by:
satrmb <10471-satrmb@users.noreply.gitlab.freedesktop.org>
-
- 15 Jun, 2022 1 commit
-
-
Peter Hutterer authored
"Meson uses Ninja which uses compiler dependency information to automatically figure out dependencies between C sources and headers, so it will rebuild things correctly when a header changes. [...] If, for whatever reason, you do add non-generated headers to the sources list of a target, Meson will simply ignore them." https://mesonbuild.com/FAQ.html#do-i-need-to-add-my-headers-to-the-sources-list-like-in-autotools Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 14 Jun, 2022 1 commit
-
-
Peter Hutterer authored
Meson supports this natively since version 0.55 which is available in all our tested distributions. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 11 Jun, 2022 3 commits
-
-
José Expósito authored
Signed-off-by:
José Expósito <jose.exposito89@gmail.com>
-
F33 and F34 are both EOL. This also fixes the RPM build job to automatically use the latest Fedora version and adds wayland-protocols-devel which is now needed. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
We have two different dependencies on Wayland: GTK support and the wayland-protocols we use directly. If we have GTK support but wayland-protocols is not installed at meson configure time, our build fails. To avoid having multiple ifdefs in the code, let's define two new ones: HAVE_GTK_WAYLAND and HAVE_GTK_X11, both set if GTK supports that particular target (from pkgconfig) and we have the other support libraries we need. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 07 Jun, 2022 5 commits
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
These two tests were identical except for the WHEEL/HWHEEL differentiator, let's make this into a ranged test instead. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
José Expósito authored
The IBM/Lenovo Scrollpoint mouse features a trackpoint-like stick that sends a great amount of scroll deltas. In order to handle the device, a quirk is in place to normalize the scroll events as they were relative motion. However, when high-resolution scroll was implemented, we started normalizing the hi-res events instead of the lo-res events by mistake. Fix the quirk by normalizing the right deltas. Fixes: 6bb02aaf ("High-resolution scroll wheel support") Signed-off-by:
José Expósito <jose.exposito89@gmail.com> Tested-by:
Peter Ganzhorn <peter.ganzhorn@gmail.com>
-
Peter Hutterer authored
If we never got an event, we'd skip over the while loop and generate a false positive. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
These tests gave us false positives for devices without a REL_WHEEL or REL_HWHEEL because one of the helper functions papered over missing events. We have two tests here, one for horizontal, one for vertical but they mixed WHEEL and HWHEEL in both tests. Fix this by splitting them properly, so each test only checks that axis. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 29 May, 2022 1 commit
-
-
satrmb authored
On mice, switching the acceleration profile to flat disables dpi normalization, because high or even switchable dpi are generally major features of a high-end mouse, and switching to flat acceleration indicates that the user wants to reduce the effects of any cursor acceleration to a minimum. Therefore we skip normalization there and let the user take full advantage of their expensive hardware. On touchpads, particularly those built into a laptop, users have to deal with whatever hardware they have; touchpad dpi is an afterthought at best, or a disaster at worst. Switching to the flat profile is more likely to be about avoiding the non-linear acceleration curve of the adaptive profile. Hence the flat profile for touchpads shouldn't copy what the one for mice does, but rather use dpi normalization like the adaptive profile. This keeps flat acceleration on low-resolution touchpads from dropping to unusably slow speeds. Signed-off-by:
satrmb <10471-satrmb@users.noreply.gitlab.freedesktop.org>
-
- 23 May, 2022 4 commits
-
-
Peter Hutterer authored
Tools default to 1% lower threshold (tip up) and 5% upper threshold (tip down). But our distance vs pressure exclusion would reset the distance for *any* pressure value, regardless how low that value was and how high distance was in comparison. A very low pressure value of less than 1% would then result in a normalized pressure of 0, so we'd effectively just reset the distance to zero and do nothing with the pressure. This can cause distance jumps when the tool arbitrarily sends low pressure values while hovering as seen in https://github.com/libsdl-org/SDL/pull/5481#issuecomment-1118969064 Commit 61bdc05f from Dec 2017 "tablet: set the tip-up pressure threshold to 1%" was presumably to address this but no longer (?) works. Fix this by addressing multiple issues at the same time: - anything under that 1% threshold is now considered as zero pressure and any distance value is kept as-is. Once pressure reaches 1%, distance is always zero. - axis normalization is now from 1% to 100% (previously: upper threshold to 100%). So a tip down event should always have ~4% pressure and we may get tablet motion events with nonzero pressure before the tip down event. From memory, this was always intended anyway since a tip event should require some significant pressure, maybe too high compared to e.g. pressure-sensitive painting - where a tablet has an offset, add the same 1%/5% thresholds, on top of that offset. And keep adjusting those thresholds as we change the offset. Assuming that the offset is the absolute minimum a worn-out pen can reach, this gives us the same behaviour as a new pen. The calculation here uses a simple approach so the actual range is slightly larger than 5% but it'll do. Previously, the lower threshold for an offset pen was the axis minimum but that can never be reached. So there was probably an undiscovered bug in there. And fix a bunch of comments that were either wrong, confusing or incomplete, e.g. the pressure thresholds were already in device coordinates. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Because --filter-test does substring matching it's easier to have it with a unique name rather than one that is a prefix of another. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
A few lines north of here we return early if neither bit is set. If we get to this point, at least one bit is set so this part of the condition always evaluates to true. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 18 May, 2022 1 commit
-
-
José Expósito authored
The file was unintentional added in a merge request: !771 Fixes: 4d26736e ("Quirk all StarLabs trackpads") Signed-off-by:
José Expósito <jose.exposito89@gmail.com>
-
- 16 May, 2022 3 commits
-
-
Quirk all the StarLabs trackpads as they are all the same design, a clickpad with physical buttons that act as one button. Fixes #771 . Signed-off-by:
Sean Rhodes <sean@starlabs.systems>
-
Peter Hutterer authored
Removed in b925a087 quirks: switch the models with missing buttonpad to use the new attr Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 09 May, 2022 3 commits
-
-
Signed-off-by:
Sean Rhodes <sean@starlabs.systems>
-
Peter Hutterer authored
This tests a bunch of internal utility functions that may work differently depending on compiler flags, etc. Let's make that test available so it can be verified on an installed system. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
We already install libinput-test-suite if the meson option install-tests is set, see commit be7045cd test: make the test suite runner available as installed binary To make other tests easily available and more discoverable, add a new tool "libinput test" with the matching man page. This will also help us to enforce some of the namespacing a bit better. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 06 May, 2022 3 commits
-
-
Peter Hutterer authored
When redirecting to a file, we don't want lines like this: .. +2 ... +5 ... +9 Let's not print anything until we have collected all those lines and then print the final result, we don't need a live update here. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Helpful in comparing values that update frequently - without this the last printed value may be way off the page when some other value comes in that it needs to be compared to. Values not seen yet default to zero - we can't query those from a recording but it'll be good enough this way. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Commit 0cdf4596 tools/record: get rid of indent push/pop, replace with fixed indents Introduced some magic to detect if there's a '-' at the start of the format string to fix the identation. This only works if the format string is constant though, leading to an indentation error when record is run with --with-libinput. Fixes 0cdf4596 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 04 May, 2022 2 commits
-
-
Otherwise redirecting the output to a file leaves us with ugly ^M Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Use --ignore ABS_X,ABS_Y or --only ABS_X,ABS_Y to ignore or limit to only a specific axis set. Especially for tablet devices with their multitudes of axes this makes analysing a particular set easier. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 26 Apr, 2022 1 commit
-
-
- 20 Apr, 2022 1 commit
-
-
Peter Hutterer authored
This fixes a format string vulnerabilty. evdev_log_message() composes a format string consisting of a fixed prefix (including the rendered device name) and the passed-in format buffer. This format string is then passed with the arguments to the actual log handler, which usually and eventually ends up being printf. If the device name contains a printf-style format directive, these ended up in the format string and thus get interpreted correctly, e.g. for a device "Foo%sBar" the log message vs printf invocation ends up being: evdev_log_message(device, "some message %s", "some argument"); printf("event9 - Foo%sBar: some message %s", "some argument"); This can enable an attacker to execute malicious code with the privileges of the process using libinput. To exploit this, an attacker needs to be able to create a kernel device with a malicious name, e.g. through /dev/uinput or a Bluetooth device. To fix this, convert any potential format directives in the device name by duplicating percentages. Pre-rendering the device to avoid the issue altogether would be nicer but the current log level hooks do not easily allow for this. The device name is the only user-controlled part of the format string. A second potential issue is the sysname of the device which is also sanitized. This issue was found by Albin Eldstål-Ahrens and Benjamin Svensson from Assured AB, and independently by Lukas Lamster. Fixes #752 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 07 Apr, 2022 1 commit
-
-
Peter Hutterer authored
Fixes 0cdf4596 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 06 Apr, 2022 1 commit
-
-
Tom Stellard authored
This updates valgrind.h to the version that was packaged in valgrind-devel-3.18.1-9.fc36. This new version contains a fix for a build failure with clang. Signed-off-by:
Tom Stellard <tstellar@redhat.com>
-
- 28 Mar, 2022 4 commits
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Removes the warning that source_root() has been deprecated since 0.56.0 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
run_command() wants a check kwarg now: WARNING: You should add the boolean check kwarg to the run_command call. It currently defaults to false, but it will default to true in future releases of meson. See also: https://github.com/mesonbuild/meson/issues/9300 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
José Expósito authored
Certain tests that make use of verify_left_handed_touch_motion can fail depending on how quick they are executed, specially when using Valgrind. Instead of ignoring the hold end event, use the existing mechanism to disable hold gestures where we are not interested in them. Signed-off-by:
José Expósito <jose.exposito89@gmail.com>
-
- 09 Mar, 2022 1 commit
-
-
Peter Hutterer authored
All cases we have in our code base have an otherwise unused variable to loop through the array. Let's auto-declare this as part of the loop. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-