Commit d6379bc3 authored by Peter Hutterer's avatar Peter Hutterer

touchpad: reduce minimum height for horiz edge scrolling to 40mm

Introduced in commit 8e7f99c2 we only allowed horizontal edge scrolling
on devices larger than 50mm to leave enough reactive space on the touchpad.
Looking at a ruler, a 50mm high touchpad is still large enough to leave the
bottom 7mm as an horizontal edge scroll area. Reduce the minimum size to 40mm
instead, that's closer to where it starts to get a bit iffy.

https://bugzilla.redhat.com/show_bug.cgi?id=1422221Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 1798cbdc
...@@ -282,14 +282,14 @@ tp_edge_scroll_init(struct tp_dispatch *tp, struct evdev_device *device) ...@@ -282,14 +282,14 @@ tp_edge_scroll_init(struct tp_dispatch *tp, struct evdev_device *device)
struct phys_coords mm = { 0.0, 0.0 }; struct phys_coords mm = { 0.0, 0.0 };
evdev_device_get_size(device, &width, &height); evdev_device_get_size(device, &width, &height);
/* Touchpads smaller than 50mm are not tall enough to have a /* Touchpads smaller than 40mm are not tall enough to have a
horizontal scroll area, it takes too much space away. But horizontal scroll area, it takes too much space away. But
clickpads have enough space here anyway because of the clickpads have enough space here anyway because of the
software button area (and all these tiny clickpads were built software button area (and all these tiny clickpads were built
when software buttons were a thing, e.g. Lenovo *20 series) when software buttons were a thing, e.g. Lenovo *20 series)
*/ */
if (!tp->buttons.is_clickpad) if (!tp->buttons.is_clickpad)
want_horiz_scroll = (height >= 50); want_horiz_scroll = (height >= 40);
/* 7mm edge size */ /* 7mm edge size */
mm.x = width - 7; mm.x = width - 7;
......
...@@ -462,7 +462,7 @@ touchpad_has_horiz_edge_scroll_size(struct litest_device *dev) ...@@ -462,7 +462,7 @@ touchpad_has_horiz_edge_scroll_size(struct litest_device *dev)
rc = libinput_device_get_size(dev->libinput_device, &width, &height); rc = libinput_device_get_size(dev->libinput_device, &width, &height);
return rc == 0 && height >= 50; return rc == 0 && height >= 40;
} }
START_TEST(touchpad_edge_scroll_horiz) START_TEST(touchpad_edge_scroll_horiz)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment