1. 13 Dec, 2018 11 commits
  2. 12 Dec, 2018 4 commits
    • Bastien Nocera's avatar
      mindtct: Fix uninitialised value usage in count_minutia_ridges() · a218437c
      Bastien Nocera authored
      libfprint/nbis/mindtct/ridges.c:153:7: warning: 1st function call argument is an uninitialized value
            free(nbr_list);
            ^~~~~~~~~~~~~~
      a218437c
    • Bastien Nocera's avatar
      bozorth3: Remove unused assignments in bz_match_score() · 0add0ca9
      Bastien Nocera authored
      libfprint/nbis/bozorth3/bozorth3.c:704:1: warning: Value stored to 'kx' is never read
      kx  = 0;
      ^     ~
      libfprint/nbis/bozorth3/bozorth3.c:820:4: warning: Value stored to 'l' is never read
                              l = 1;
                              ^   ~
      0add0ca9
    • Bastien Nocera's avatar
      mindtct: Fix memory leaks in get_centered_contour() · eaa4aa96
      Bastien Nocera authored
      The first contour wasn't freed if we failed on the second contour.
      
      libfprint/nbis/mindtct/contour.c:521:14: warning: Potential leak of memory pointed to by 'half1_ex'
            return(ret);
                   ^~~
      libfprint/nbis/mindtct/contour.c:521:14: warning: Potential leak of memory pointed to by 'half1_ey'
            return(ret);
                   ^~~
      libfprint/nbis/mindtct/contour.c:521:14: warning: Potential leak of memory pointed to by 'half1_x'
            return(ret);
                   ^~~
      libfprint/nbis/mindtct/contour.c:521:14: warning: Potential leak of memory pointed to by 'half1_y'
            return(ret);
                   ^~~
      eaa4aa96
    • Bastien Nocera's avatar
      mindtct: Fix "garbage value" error in dft_dir_powers() · 74bb899c
      Bastien Nocera authored
      libfprint/nbis/mindtct/dft.c:212:30: warning: The left operand of '*' is a garbage value
            cospart += (rowsums[i] * wave->cos[i]);
                        ~~~~~~~~~~ ^
      74bb899c
  3. 12 Oct, 2018 3 commits
  4. 27 Aug, 2018 5 commits
    • Bastien Nocera's avatar
      loop: Remove unused variable · 821cbae1
      Bastien Nocera authored
      mindtct/loop.c: In function ‘process_loop_V2’:
      mindtct/loop.c:713:8: warning: variable ‘halfway’ set but not used [-Wunused-but-set-variable]
          int halfway;
              ^~~~~~~
      821cbae1
    • Bastien Nocera's avatar
      morph: Fix misleading indentation · 688a133f
      Bastien Nocera authored
      mindtct/morph.c: In function ‘get_south8_2’:
      mindtct/morph.c:173:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
          if (row >= ih-1) /* catch case where image is undefined southwards   */
          ^~
      mindtct/morph.c:176:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
             return *(ptr+iw);
             ^~~~~~
      mindtct/morph.c: In function ‘get_north8_2’:
      mindtct/morph.c:197:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
          if (row < 1)     /* catch case where image is undefined northwards   */
          ^~
      mindtct/morph.c:200:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
             return *(ptr-iw);
             ^~~~~~
      mindtct/morph.c: In function ‘get_east8_2’:
      mindtct/morph.c:221:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
          if (col >= iw-1) /* catch case where image is undefined eastwards    */
          ^~
      mindtct/morph.c:224:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
             return *(ptr+ 1);
             ^~~~~~
      mindtct/morph.c: In function ‘get_west8_2’:
      mindtct/morph.c:243:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
          if (col < 1)     /* catch case where image is undefined westwards     */
          ^~
      mindtct/morph.c:246:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
             return *(ptr- 1);
             ^~~~~~
      688a133f
    • Bastien Nocera's avatar
      block: Remove unused variable · 0cd37b01
      Bastien Nocera authored
      mindtct/block.c: In function ‘block_offsets’:
      mindtct/block.c:108:18: warning: variable ‘ph’ set but not used [-Wunused-but-set-variable]
          int pad2, pw, ph;
                        ^~
      0cd37b01
    • Bastien Nocera's avatar
      nbis: Update to NBIS 5.0.0 · 9fb789dc
      Bastien Nocera authored
      This updates NBIS to its latest 5.0.0 version, dated 04/03/2015, from a
      1.x version, dated 2007.
      
      Original sources are available at:
      https://www.nist.gov/itl/iad/image-group/products-and-services/image-group-open-source-server-nigos#Releases
      
      And full change log at:
      https://www.nist.gov/sites/default/files/documents/2016/12/14/changelog.txt
      9fb789dc
    • Bastien Nocera's avatar
      nbis: Add script to update NBIS and apply changes · 770444af
      Bastien Nocera authored
      NBIS is pretty complicated to update, seeing as we've made quite a few
      changes to get it to compile as a library. With those scripts, we can
      easily trim headers to remove functions we don't use, rename global
      variables, and do any sort of fixups that are necessary right now.
      
      In the future, removing unused NBIS functions might be as easy as
      updating that script, re-running it, and pushing the changes.
      
      Note that remove-function.lua is a very crude parser that only supports
      NBIS' style of declaration, with the return type on the same line as the
      function name. I wouldn't recommend trying to use it in another project.
      
      Callcatcher (https://github.com/caolanm/callcatcher) was also used to
      remove additional unused functions.
      770444af
  5. 02 Jun, 2018 1 commit
  6. 11 Mar, 2018 1 commit
    • Mark Harfouche's avatar
      mindtct: Fix compilation warnings · 54deaa1b
      Mark Harfouche authored
      nbis/mindtct/morph.c:152:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
      nbis/mindtct/morph.c:176:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
      nbis/mindtct/morph.c:200:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
      nbis/mindtct/morph.c:222:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
      
      https://bugs.freedesktop.org/show_bug.cgi?id=105429
      54deaa1b
  7. 16 Dec, 2015 1 commit
  8. 03 Dec, 2012 1 commit
  9. 06 Nov, 2012 2 commits
  10. 17 Nov, 2007 1 commit
    • Daniel Drake's avatar
      Rework some image handling; add public binarization API · ba24c088
      Daniel Drake authored
      I want to offer the ability for an application to view a binarized
      version of a scanned print. This lead onto a few changes:
      
       1. Store minutiae and binarized data inside fp_img
       2. Move resize code to the capture path, it previously happened much
          later.
       3. Add fp_img_binarize() to return a new image in binarized form.
       4. Add a BINARIZED_FORM flag to prevent an image being binarized again.
      
      In future, it would be nice to be able to binarize without detecting
      minutiae, but this involves some work on the NBIS interaction.
      ba24c088
  11. 30 Oct, 2007 1 commit
  12. 28 Oct, 2007 2 commits
  13. 27 Oct, 2007 1 commit