1. 13 Nov, 2018 3 commits
    • Bastien Nocera's avatar
      vfs101: Fix warning about value truncation · e5f4021a
      Bastien Nocera authored
      libfprint/drivers/vfs101.c:854:6: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
              if (abs(count - VFS_IMG_BEST_CONTRAST) < abs(vdev->best_clevel - VFS_IMG_BEST_CONTRAST))
                  ^
      libfprint/drivers/vfs101.c:854:6: note: use function 'labs' instead
              if (abs(count - VFS_IMG_BEST_CONTRAST) < abs(vdev->best_clevel - VFS_IMG_BEST_CONTRAST))
                  ^~~
                  labs
      e5f4021a
    • Bastien Nocera's avatar
      vfs101: Fix typo in "VFS_IMG_BEST_CONRAST" constant · 4dcbc6a3
      Bastien Nocera authored
      It's contrast, says so above the definition.
      4dcbc6a3
    • Bastien Nocera's avatar
      lib: Fix uninitialised variable in fpi_imgdev_image_captured() · 7a72d8fd
      Bastien Nocera authored
      libfprint/fpi-dev-img.c:255:6: warning: variable 'print' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
              if (imgdev->action != IMG_ACTION_CAPTURE) {
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/fpi-dev-img.c:271:25: note: uninitialized use occurs here
              imgdev->acquire_data = print;
                                     ^~~~~
      libfprint/fpi-dev-img.c:255:2: note: remove the 'if' if its condition is always true
              if (imgdev->action != IMG_ACTION_CAPTURE) {
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/fpi-dev-img.c:232:29: note: initialize the variable 'print' to silence this warning
              struct fp_print_data *print;
                                         ^
                                          = NULL
      7a72d8fd
  2. 12 Nov, 2018 1 commit
  3. 09 Nov, 2018 18 commits
  4. 23 Oct, 2018 15 commits
  5. 12 Oct, 2018 3 commits
    • Bastien Nocera's avatar
      lib: Fix crash when too many minutiae were detected · 3a7b03f0
      Bastien Nocera authored
      struct xyt_struct uses a fixed-sized array to fit MAX_BOZORTH_MINUTIAE (200)
      minutiae. MAX_FILE_MINUTIAE is 1000. So if we detected more than
      MAX_BOZORTH_MINUTIAE, we would crash copying the data from the capture
      to the structure.
      
      We might want to use dynamically allocated arrays in the future (or
      bigger ones) so that we don't lose minutiae.
      
      Closes: #116
      3a7b03f0
    • Bastien Nocera's avatar
      lib: Fix fpi_img_is_sane() · 94450a1d
      Bastien Nocera authored
      The checks weren't:
      - checking whether the width or height were negative
      - whether img->width * img->height would overflow, or
        was bigger than G_MAXINT
      - whether img->width * img->height was bigger than the total
        length of the buffer
      
      The last one looks like a thinko, it checked for:
      (img->length * img->height) < img->length
      which is equivalent to:
      img->height < 1
      which we already check for earlier.
      
      Closes: #85
      94450a1d
    • Bastien Nocera's avatar
      mindtct: Fix a memory leak in morph_TF_map() · c35ad202
      Bastien Nocera authored
      cimage is leaked when mimage fails to allocate.
      
      Spotted by Seth Arnold
      
      Closes: #82
      c35ad202