Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libfprint
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • libfprint
  • libfprint
  • Merge requests
  • !217

elan: Add support for touch devices

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Piotr Piastucki requested to merge ppiastucki/libfprint:elan_touch_subclass into master Dec 13, 2020
  • Overview 4
  • Commits 1
  • Pipelines 3
  • Changes 8

Despite being listed in the supported devices my Elan reader (0x0c28) can be hardly used with libfrint currently. Here is my attempt at addressing the issues and making the reader usable. Some obvious changes are based directly on https://github.com/iafilatov/libfprint/tree/elan-touch. Other noteworthy changes:

  • the number of calibration loops was increased as otherwise it was not possible to complete the enrollment at all (it fails at every second capture)
  • some handling for 0xaf was added CAPTURE_READ_DATA; I do not know what the code means but it is return relatively often and prevents the enrollment from completion
  • bz3_threshold was decreased due to the reader's low resolution and poor image quality
  • the original image is resized to make minutiae extraction work (resizing is enough to extract a bunch of minutiae from a single frame)
  • a simple sharpening convolution filter is applied to the resized image to improve minutiae extraction (usually doubles the number of extracted minutiae)

Even if you decide not to include the whole PR I would like to ask you to consider increasing the number of calibration loops and adding some handling for the 0xaf result code as otherwise it is literaly impossible to enroll even in the swipe mode.

Edited Dec 14, 2020 by Piotr Piastucki
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: elan_touch_subclass