The state was always AWAIT_FINGER and it was never used by any driver
(except for error checking). So remove it, in particular as a correct
state change will be done after activation anyway.

The only driver with code that actually did anything based on this was
the URU4000 driver. However, all it did was an explicit state change
execution. This is not necessary, as the state_change handler is called
anyway (i.e. we now only write the AWAIT_FINGER register once rather
than twice).

Manual changes plus:

@ init @
identifier driver_name;
identifier activate_func;
@@
struct fp_img_driver driver_name = {
    ...,
    .activate = activate_func,
    ...,
};
@ remove_arg @
identifier dev;
identifier state;
identifier init.activate_func;
@@
activate_func (
	struct fp_img_dev *dev
-	, enum fp_imgdev_state state
	)
{
	<...
-	if (state != IMGDEV_STATE_AWAIT_FINGER_ON) { ... }
	...>
}

Benjamin Berg authored Jun 18, 2019 and Benjamin Berg committed Jun 18, 2019

The driver was never ported to the new asynchronous model, meaning it
has been defunct since some time in 2008. Remove the driver, as
seemingly no one has complained about this and we have no proper way to
even verify a port is correct.

Benjamin Berg authored Jun 13, 2019 and Benjamin Berg committed Jun 13, 2019

This ports the enroll and verify examples to the new storage so that
they do not need any deprecated API anymore.

Benjamin Berg authored Jun 13, 2019 and Benjamin Berg committed Jun 13, 2019

For now just compile and link it, we do not yet use the new storage
code.

Benjamin Berg authored Jun 13, 2019 and Benjamin Berg committed Jun 13, 2019

This is useful so that the enroll and verify examples will not use the
deprecated API anymore.

libfprint already uses G_DEBUG_HERE in a lot of places which requires
GLib 2.50. Also add the appropriate defines so that usage of newer API
will result in warnings.

There is no need to list them in the sources.

There is no need to list them in the sources.

It is not necessary to list all the headers in the drivers_sources list,
so remove them.

The upekts driver needs upek_proto.c while the upektc driver does not.
Move the corresponding source file entries so that both drivers compile
standalone.

The only API user currently seems to be the examples. fprintd has its
own storage and that will be a good idea in general.

So deprecate the API, we'll need to find a different solution for the
examples eventually.

Add appropriate g_return_val_if_fail macros to all public API functions
to guard against NULL pointers being passed into libfprint.

The function was committed by accident as part of commit d18e1053
(lib: Add a way to name timeouts). It is not used anywhere and
fpi_timeout_cancel_all_for_dev exists, is exported and used and serves
the same purpose.

Dave.wang authored Apr 09, 2019 and Bastien Nocera committed Jun 06, 2019

Now that all the quirks are in place to support it.

Dave.wang authored Apr 09, 2019 and Bastien Nocera committed Jun 06, 2019

If users put their finger on the sensor between the bulge and
"un-bulge" area first and then swipe, the captured image would
be bad.

Skipping more frames can reduce the impact, so bump
ELAN_SKIP_LAST_FRAMES to 2.

Dave.wang authored Apr 09, 2019 and Bastien Nocera committed Jun 06, 2019

Check for the mean calibration being outside of range to know whether we
require a recalibration. Continue with the usual checks if the
calibration value is within range.

Dave.wang authored Apr 09, 2019 and Bastien Nocera committed Jun 06, 2019

Split off calibration support checks into elan_supports_calibration()

Dave.wang authored Apr 09, 2019 and Bastien Nocera committed Jun 06, 2019

On the ELAN_0C42 device, one-byte responses are 2 bytes long.
Adapt our expected response length.

Dave.wang authored Apr 09, 2019 and Bastien Nocera committed Jun 06, 2019

The dimensions some sensors return is the maximum zero-based index
rather than the number of pixels. Assuming every sensor has an
even number of pixels is safe.

The call to sleep(1) inside of the enrollment loop caused a crash
on at least the etes603 driver.

Because in fp_enroll_finger_img the function enters an event
handling loop. This loop needs to start before the next libusb
event timeout. Which would not happen in the etes603 driver
because the timeout there was set to 1 second as well.

This commit fixes a hang in gnome-settings when trying to enroll a finger.

The same issue could be seen in the enroll example. Previously the enroll
example would hang on "deactivating" because at some point dev->is_active
is set to false and m_exit_start is never called.

Diego authored May 05, 2019 and Bastien Nocera committed May 06, 2019

Add support for the Lenovo Preferred Pro USB Fingerprint Keyboard KUF1256
by declaring support for USB ID 138a:0015.

Closes: #125

Work-around SELinux AVC warnings caused by p11-kit (which is an NSS
dependency) trying to load the root user's p11-kit configs. We disable
this feature using the P11_KIT_NO_USER_CONFIG envvar.

See https://bugzilla.redhat.com/show_bug.cgi?id=1688583

‘img->key_number’ variable is originally from the device through bulk
endpoint of USB. The variable is immediately assigned to ‘buf[0]’ for
sending to control endpoint of the device. Here, integer overflow may
occur when the ‘img->key_number’ attempts to assign a value that is
outside of type range of ‘char’ to the ‘buf[0]’

Given that it's not usable yet.

Handle the empty list output from fp_discover_devs() when there are no
supported devices.

Closes: #146

Document the behaviour of fp_discover_devs() when there are no supported
devices, rather than errors listing the devices.