Marco Trevisan authored Jan 22, 2020 and Bastien Nocera committed Feb 05, 2020

Reuse the generated dbus interface .xml files from fprintd to avoid
unnecessary copies.

Marco Trevisan authored Feb 05, 2020 and Bastien Nocera committed Feb 05, 2020

Don't hardcode the libtool specific build path in the configuration
file, but in the build declaration instead.

Marco Trevisan authored Jan 31, 2020 and Bastien Nocera committed Feb 04, 2020

Like for the fprintd test, run the tests under valgrind if the `VALGRIND`
environment variable is set, and use the contents of the variable as the
path to the suppression file.

Marco Trevisan authored Jan 31, 2020 and Bastien Nocera committed Feb 04, 2020

It's marked as a signed integer, not an unsigned one in the API.

Marco Trevisan authored Jan 29, 2020 and Bastien Nocera committed Feb 04, 2020

Use the device session data to store all the informations we care about
while a device is claimed, and make its cleanup easier.

Keep just one instance of the current context, given we use it only during
claim and release, and those are mutually exclusive operations.

Marco Trevisan authored Jan 29, 2020 and Bastien Nocera committed Feb 04, 2020

Allocate SessionData using g_malloc(). There are no benefits to using
GSlice for a seldom used structure. This also allows use to use
g_clear_pointer() to free the struct.

Marco Trevisan authored Jan 29, 2020 and Bastien Nocera committed Feb 04, 2020

Add the missing chain-up on finalize().

Closes: #3

Don't use return messages for D-Bus calls when we're not interested in
those return values.

If we exited early from the loop, we need to make sure to free() this
struct member.

We need to make sure that the max_tries variable isn't decremented
further when we have success in the verification loop. Add missing break
to do that.

Fixes: affffaf1
Closes: #40

Exhaust all the tries (minus 1) before having a match on the last try.
This should not throw a warning.

As used in the dist tarball.

Closes: #24

Remove "nodelete" linker flag now that we use sd-bus and not dbus-glib,
so that libraries that pam_fprintd links to can be unloaded.

This was added because GLib's type system expects to be initialised
once and only once per process, and re-loading this type system when it
had already been initialised caused crashes.

This will catch problems with GLib being unloaded when the PAM module is
unloaded, which would have crashed when using dbus-glib.

This serves as a test for #2

Closes: #2

Support debug=[on|off|true|false|1|0] as an option in addition to
"debug".

Should prove useful debugging the PAM module if we need it.

This pam plugin never used GDBus because it transparently uses threads
which do not work well with a lot of PAM applications. But even settling
on the "still better to use than plain dbus library" dbus-glib wasn't
without problems, as any use or initialisation of GIO sockets would
modify signal handler for signals such as SIGPIPE (see gio/gsocket.c).

Many years later, sd-bus is a more modern alternative to the bare dbus
library with a better API.

This includes:
- Removing use of gboolean, guint, g_new0() and many glib string helpers
- Simplifying debug logging
- Marking user-facing messages to be translated

To simplify the options parsing.