This reverts commit 526b2e8c.

Commit 0994cc31 was enough to implement the coverage support.

Now that it won't clash with the autotools version.

It's empty and was only there to satisfy the autotools.

It was an autotools file, and doesn't contain useful information
anymore.

Marco Trevisan authored Feb 05, 2020 and Bastien Nocera committed Feb 05, 2020

When coverage is enabled, we need to expose the __gcov_* symbols in the
binaries and libraries or we won't get any coverage report for them.

When coverage is enabled fprintd test won't generate any .gcda file and so
apparently no data, this happens because gcov doesn't handle properly the
process termination when SIGTERM is used, and so when in fprintd.py we
terminate the process no coverage data is reported.

To avoid this, quit the main loop cleanly on SIGTERM, so that we will exit
from the main function cleanly, making libc to perform a gcov flush when we
exit the program.

Marco Trevisan authored Jan 28, 2020 and Bastien Nocera committed Feb 05, 2020

utils/verify.c:191:12: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
191 |   username = "";
    |            ^

Marco Trevisan authored Feb 05, 2020 and Bastien Nocera committed Feb 05, 2020

usernames was not freed on exit.

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

Given that finger_name is set by GOptionEntry, make sure it's always
using allocated memory.

../utils/enroll.c:38:28: error: initialization discards ‘const’ qualifier
  from pointer target type [-Werror=discarded-qualifiers]
38 | static char *finger_name = "right-index-finger";
   |                            ^~~~~~~~~~~~~~~~~~~~

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

Now that we've fixed our own errors.

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

There's no need to declare it as extern in the header as it is already
declared in the source files where it's used.

Fixes:
../src/device.c:51:25: error: redundant redeclaration of ‘fprintd_dbus_conn’ [-Werror=redundant-decls]
  51 | extern DBusGConnection *fprintd_dbus_conn;
     |                         ^~~~~~~~~~~~~~~~~
In file included from ../src/device.c:34:
../src/fprintd.h:29:25: note: previous declaration of ‘fprintd_dbus_conn’ was here
  29 | extern DBusGConnection *fprintd_dbus_conn;
     |                         ^~~~~~~~~~~~~~~~~

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

../src/file_storage.c:47:20: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
47 | static const char *get_storage_path()
   |                    ^~~~~~~~~~~~~~~~
../src/file_storage.c: In function ‘get_storage_path’:
../src/file_storage.c:47:20: warning: old-style function definition [-Wold-style-definition]
../src/file_storage.c: In function ‘file_storage_discover_users’:
../src/file_storage.c:270:9: warning: old-style function definition [-Wold-style-definition]
270 | GSList *file_storage_discover_users()
    |         ^~~~~~~~~~~~~~~~

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

With the stronger warnings enabled when building with meson, we get a
warning for all the fingers definitions:

  ../src/device.c:38:24: warning: initialization discards ‘const’ qualifier
  from pointer target type [-Wdiscarded-qualifiers]
    38 |  [FP_FINGER_UNKNOWN] = "unknown",

As the `fingers` array name was shadowed in another file:

  ../src/device.c:1000:11: warning: declaration of ‘fingers’ shadows a
  global declaration [-Wshadow]
    1000 |   GSList *fingers, *finger;

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

Use a bash script to check the translations as we used to do during
the autotools-based distcheck.

Marco Trevisan authored Jan 27, 2020 and Bastien Nocera committed Feb 05, 2020

Recent versions of gettext can merge translations in xml files,
so use it and remove the intltool dependency for meson builds.

Marco Trevisan authored Jan 22, 2020 and Bastien Nocera committed Feb 05, 2020

Reuse the generated dbus interface .xml files from fprintd to avoid
unnecessary copies.

Marco Trevisan authored Feb 05, 2020 and Bastien Nocera committed Feb 05, 2020

Don't hardcode the libtool specific build path in the configuration
file, but in the build declaration instead.

Marco Trevisan authored Jan 31, 2020 and Bastien Nocera committed Feb 04, 2020

Like for the fprintd test, run the tests under valgrind if the `VALGRIND`
environment variable is set, and use the contents of the variable as the
path to the suppression file.

Marco Trevisan authored Jan 31, 2020 and Bastien Nocera committed Feb 04, 2020

It's marked as a signed integer, not an unsigned one in the API.

Marco Trevisan authored Jan 29, 2020 and Bastien Nocera committed Feb 04, 2020

Use the device session data to store all the informations we care about
while a device is claimed, and make its cleanup easier.

Keep just one instance of the current context, given we use it only during
claim and release, and those are mutually exclusive operations.