The __-prefixed types cannot be assumed to be defined. Use the standard
types instead.

Closes: #6

Closes: !11

Based-on-patch-by: cptpcrd <cptpcrd.git@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>

cptpcrd authored Feb 07, 2021 and Guillem Jover committed Feb 08, 2021

More important if close_range() is going to be used, since casting
negative values to 'unsigned int' might hide the errors.

[guillem@hadrons.org: Minor coding style fix. ]
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Take most of the changes done in sudo, but preserve the existing local
changes and refactoring.

In addition, refactor pstat implementation into closefrom_pstat(), so
that the code is easier to read, and requires no conditional
declarations.

Faidon Liambotis authored Feb 07, 2021 and Guillem Jover committed Feb 08, 2021

This brings <sys/queue.h> to the most up-to-date version from FreeBSD,
incorporating 18 commits from the past 5 years (2015-02-24 - 2021-01-25):

  $ git log --oneline 9090a24aed70..8d55837dc133 sys/sys/queue.h share/man/man3/queue.3

Only minimal changes compared to the FreeBSD version have been applied
(queue.3 -> queue.3bsd, _LIBBSD_ prefix).

[guillem@hadrons.org: Remove reference to kernel mode in man page. ]

Closes: !12

Signed-off-by: Guillem Jover <guillem@hadrons.org>

This will make it possible to explicitly select the OpenBSD vis
implementation (the current default) for code of OpenBSD origins.

This splits the implementation responsibilities, and reduces embedded
code copies, which was one of the driving points with this project to
start with, so it's nice to give a good example.

Aaron Dierking authored Jul 05, 2018 and Guillem Jover committed Feb 07, 2021

[guillem@hadrons.org:
 - Remove .exe extension from default program name.
 - Call reallocarray() once by switching to a «do {} while» loop.
 - Minor coding style fixes. ]
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Warned-by: lintian
Fixes: commit 01f0d1ea

Faidon Liambotis authored Dec 31, 2020 and Guillem Jover committed Jan 01, 2021

Add recallocarray(), introduced in OpenBSD 6.1, and freezero(),
introduced in OpenBSD 6.2. The former is imported as-is from OpenBSD,
while the latter is the non-malloc-internal branch of the same code (and
also the OpenSSH portable variant).

Both of these originated in OpenBSD, but have also been implemented by
IllumOS, cf. https://www.illumos.org/issues/8546

Documentation for these functions is in malloc(3) upstream, the relevant
parts of which were previously imported in reallocarray(3bsd). Update
reallocarray(3bsd) with the changes that were introduced since, and add
the relevant bits for recallocarray() and freezero(), plus aliases.

[guillem@hadrons.org: Update copyright in COPYING. ]

Closes: !10

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Seth R. Johnson authored Nov 14, 2019 and Guillem Jover committed Jan 01, 2021

The Intel compiler does not define __amd64__ on x86_64 platforms;
instead, like other compilers, it defines __x86_64__ .

Closes: !8

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Even though man-pages project now includes man pages for system data
types, we still include these for any other system that does not have
them, to provide a self-contained project with code and documentation.

These are non-issues, but having a clean ASAN test suite makes it
possible to detect actual problems in the tested code.

Warned-by: gcc ASAN

We need to free the cookiewrap even when the closefn method is NULL.

Warned-by: gcc ASAN

Fixes: commit 99320b91.

Fixes: commit 2d7de186.

Some systems such as Windows or musl-libc based ones do not have these
BSD extensions. In addition libbsd itself is making use of the warnx()
functions, so we better provide these interfaces in case they are
missing.

Do not depend on the system vwarn() and verr() functions to implement
the *c() variants, as the system might actually lack any of the <err.h>
BSD extensions.

Michael Shigorin authored Aug 07, 2019 and Guillem Jover committed Aug 08, 2019

This is a Russian 64-bit LE VLIW architecture named Elbrus
(formerly Elbrus 2000).

[guillem@hadrons.org:
 - Place the entry in alphabetical order. ]
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Frank Schaefer authored May 28, 2019 and Guillem Jover committed Aug 08, 2019

Closes: !7

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Rosen Penev authored May 17, 2019 and Guillem Jover committed Aug 08, 2019

Closes: !6

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>

This should help people wanting to add new entries.

Jessica Clarke authored Feb 03, 2019 and Guillem Jover committed Aug 08, 2019

Commit e8d340de ("Remove a.out support from nlist()") introduced a copy
of the definition of nlist from a.out.h. However, as well as having
n_name inside n_un, on the various BSDs n_name could also be accessed
as a direct member of nlist, and this is made use of by FreeBSD's
usr.bin/netstat/main.c. Thus we should also add the same enclosing
anonymous union.

[guillem@hadrons.org:
 - Add a minimal unit test. ]

Closes: !4

Signed-off-by: Guillem Jover <guillem@hadrons.org>

When doing a string comparison for a symbol name from the string table,
we should make sure we do a bounded comparison, otherwise a non-NUL
terminated string might make the code read out-of-bounds.

Warned-by: coverity

There are a couple of malloc() calls with unbounded size arguments,
coming from the parsed file. We need to make sure the size is not
larger than the file being parsed, otherwise we might end up with
out of memory conditions.
Reported-by: Daniel Hodson <daniel@elttam.com.au>
Signed-off-by: Guillem Jover <guillem@hadrons.org>