1. 23 Jan, 2014 1 commit
  2. 12 Dec, 2013 2 commits
  3. 28 Oct, 2013 2 commits
  4. 17 Oct, 2013 1 commit
    • Paul Berry's avatar
      glsl: In update_max_array_access, fix interface instance check. · e2d1eaa3
      Paul Berry authored
      In commit f878d206 (glsl: Update ir_variable::max_ifc_array_access
      properly), I accidentally used the wrong kind of check to determine
      whether the variable being accessed was an interface instance (I used
      var->get_interface_type() != NULL when I should have used
      var->is_interface_instance()).  As a result, if an unnamed interface
      block contained a struct which contained an array,
      update_max_array_access() would mistakenly interpret the struct as a
      named interface block and try to dereference a null
      var->max_ifc_array_access.
      
      This patch corrects the check, fixing the null dereference.
      
      Fixes piglit test interface-block-struct-nesting.
      
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70368Reviewed-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
      e2d1eaa3
  5. 09 Oct, 2013 2 commits
    • Paul Berry's avatar
      glsl: Update ir_variable::max_ifc_array_access properly. · f878d206
      Paul Berry authored
      This patch modifies update_max_array_access() so that it updates
      ir_variable::max_ifc_array_access to reflect the shader's use of
      arrays appearing within interface blocks.
      
      v2: Use an ordinary function in ast_array_index.cpp rather than a
      virtual function in ir_rvalue.  Avoid dereferencing NULL when handling
      accesses to ordinary structs.
      Reviewed-by: Jordan Justen's avatarJordan Justen <jordan.l.justen@intel.com>
      f878d206
    • Paul Berry's avatar
      glsl: Move update of max_array_access into a separate function. · 6f19e552
      Paul Berry authored
      Currently, when converting an access to an array element from ast to
      IR, we need to see if the array is an ir_dereference_variable, and if
      so update the variable's max_array_access.
      
      When we add support for unsized arrays in interface blocks, we'll also
      need to account for cases where the array is an ir_dereference_record
      and the record is an interface block.
      
      To make this easier, move the update into its own function.
      
      v2: Use an ordinary function in ast_array_index.cpp rather than a
      virtual function in ir_rvalue.
      Reviewed-by: Jordan Justen's avatarJordan Justen <jordan.l.justen@intel.com>
      6f19e552
  6. 02 Aug, 2013 1 commit
  7. 13 May, 2013 1 commit
  8. 08 Apr, 2013 6 commits