Skip to content
  • Timothy Arceri's avatar
    mesa: fix active subroutine uniforms properly · 0303201d
    Timothy Arceri authored
    07fe2d56 introduced a big hack in order to return
    NumSubroutineUniforms when querying ACTIVE_RESOURCES for
    <shader>_SUBROUTINE_UNIFORM interfaces. However this is the
    wrong fix we are meant to be returning the number of active
    resources i.e. the count of subroutine uniforms in the
    resource list which is what the code was previously doing,
    anything else will cause trouble when trying to retrieve
    the resource properties based on the ACTIVE_RESOURCES count.
    
    The real problem is that NumSubroutineUniforms was counting
    array elements as separate uniforms but the innermost array
    is always considered a single uniform so we fix that count
    instead which was counted incorrectly in 7fa0250f
    
    .
    
    Idealy we could probably completely remove
    NumSubroutineUniforms and just compute its value when needed
    from the resource list but this works for now.
    
    Reviewed-by: default avatarAlejandro Piñeiro <apinheiro@igalia.com>
    Reviewed-by: default avatarTapani Pälli <tapani.palli@intel.com>
    Cc: 13.0 <mesa-stable@lists.freedesktop.org>
    0303201d