Commit bc66cebc authored by Samuel Iglesias Gonsálvez's avatar Samuel Iglesias Gonsálvez Committed by Iago Toral

anv: fix alphaToCoverage when there is no color attachment

There are tests in CTS for alpha to coverage without a color attachment
that are failing. This happens because we remove the shader color
outputs when we don't have a valid color attachment for them, but when
alpha to coverage is enabled we still want to preserve the the output
at location 0 since we need the alpha component. In that case we will
also need to create a null render target for RT 0.

v2:
  - We already create a null rt when we don't have any, so reuse that
    for this case (Jason)
  - Simplify the code a bit (Iago)

v3:
  - Take alpha to coverage from the key and don't tie this to depth-only
    rendering only, we want the same behavior if we have multiple render
    targets but the one at location 0 is not used. (Jason).
  - Rewrite commit message (Iago)

v4:
  - Make sure we take into account the array length of the shader outputs,
    which we were no handling correctly either and make sure we also
    create null render targets for any invalid array entries too.

v5:
  - Simplify removal of unused outputs by using rt_used[] so we don't have
    to special case alpha to coverage there too.

Fixes the following CTS tests:
dEQP-VK.pipeline.multisample.alpha_to_coverage_no_color_attachment.*
Signed-off-by: Samuel Iglesias Gonsálvez's avatarSamuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Iago Toral's avatarIago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
parent c8665005
......@@ -825,14 +825,24 @@ anv_pipeline_link_fs(const struct brw_compiler *compiler,
continue;
const unsigned rt = var->data.location - FRAG_RESULT_DATA0;
/* Unused or out-of-bounds */
if (rt >= MAX_RTS || !(stage->key.wm.color_outputs_valid & (1 << rt)))
/* Out-of-bounds */
if (rt >= MAX_RTS)
continue;
const unsigned array_len =
glsl_type_is_array(var->type) ? glsl_get_length(var->type) : 1;
assert(rt + array_len <= max_rt);
/* Unused */
if (!(stage->key.wm.color_outputs_valid & BITFIELD_RANGE(rt, array_len))) {
/* If this is the RT at location 0 and we have alpha to coverage
* enabled we will have to create a null RT for it, so mark it as
* used.
*/
if (rt > 0 || !stage->key.wm.alpha_to_coverage)
continue;
}
for (unsigned i = 0; i < array_len; i++)
rt_used[rt + i] = true;
}
......@@ -843,11 +853,22 @@ anv_pipeline_link_fs(const struct brw_compiler *compiler,
continue;
rt_to_bindings[i] = num_rts;
rt_bindings[rt_to_bindings[i]] = (struct anv_pipeline_binding) {
.set = ANV_DESCRIPTOR_SET_COLOR_ATTACHMENTS,
.binding = 0,
.index = i,
};
if (stage->key.wm.color_outputs_valid & (1 << i)) {
rt_bindings[rt_to_bindings[i]] = (struct anv_pipeline_binding) {
.set = ANV_DESCRIPTOR_SET_COLOR_ATTACHMENTS,
.binding = 0,
.index = i,
};
} else {
/* Setup a null render target */
rt_bindings[rt_to_bindings[i]] = (struct anv_pipeline_binding) {
.set = ANV_DESCRIPTOR_SET_COLOR_ATTACHMENTS,
.binding = 0,
.index = UINT32_MAX,
};
}
num_rts++;
}
......@@ -857,9 +878,11 @@ anv_pipeline_link_fs(const struct brw_compiler *compiler,
continue;
const unsigned rt = var->data.location - FRAG_RESULT_DATA0;
if (rt >= MAX_RTS ||
!(stage->key.wm.color_outputs_valid & (1 << rt))) {
/* Unused or out-of-bounds, throw it away */
if (rt >= MAX_RTS || !rt_used[rt]) {
/* Unused or out-of-bounds, throw it away, unless it is the first
* RT and we have alpha to coverage enabled.
*/
deleted_output = true;
var->data.mode = nir_var_function_temp;
exec_node_remove(&var->node);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment