1. 09 May, 2019 15 commits
  2. 08 May, 2019 25 commits
    • Dave Airlie's avatar
      kmsro: add _dri.so to two of the kmsro drivers. · 0a42d5b9
      Dave Airlie authored
      Fixes: 8cfc17bd (kmsro: Add the rest of the current set of tinydrm drivers.)
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      0a42d5b9
    • Kenneth Graunke's avatar
      iris: Report the same video memory settings as i965. · d9b9bb91
      Kenneth Graunke authored
      This just copy and pastes Ian's code from i965.
      d9b9bb91
    • Eric Engestrom's avatar
    • Eric Engestrom's avatar
      gitlab-ci: add the vulkan overlay layer to the vulkan build · c6306125
      Eric Engestrom authored
      Signed-off-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      Reviewed-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      
      [ Michel Dänzer: Take changes affecting the docker image from !299,
        plus remove the unzip package again before generating the image ]
      c6306125
    • Michel Dänzer's avatar
      gitlab-ci: Don't install WINE packages · fcf75534
      Michel Dänzer authored
      They were just making the docker image larger for no benefit at this
      point.
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      fcf75534
    • Michel Dänzer's avatar
      gitlab-ci: Reorder jobs a bit to be generally ordered longer => shorter · 82b30094
      Michel Dänzer authored
      This makes the longer jobs likely to run earlier, which can help the
      overall pipeline duration.
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      82b30094
    • Michel Dänzer's avatar
      gitlab-ci: Build clover against all supported versions of LLVM · 68977157
      Michel Dänzer authored
      And consolidate it all into a single job.
      
      It doesn't take much longer than a single version, thanks to ccache.
      Overall, this single job might be faster or at least use fewer CPU
      cycles than the two jobs before, while covering thrice as many versions
      of LLVM.
      
      v2:
      * Move "rm -rf _build" to meson-build.sh.
      * Set GALLIUM_DRIVERS the same way both times in the meson-clover job,
        for symmetry.
      
      Reviewed-by: Eric Engestrom <eric.engestrom@intel.com> # v1
      68977157
    • Michel Dänzer's avatar
      gitlab-ci: Move meson job script to separate file · cc2b3a99
      Michel Dänzer authored
      No functional change intended (except for no longer running meson
      --version separately, as the version appears early in meson's output
      anyway).
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      cc2b3a99
    • Michel Dänzer's avatar
      gitlab-ci: Remove superfluous comment about image tag counter suffix · d0b9a7f0
      Michel Dänzer authored
      We really shouldn't ever need a suffix, otherwise it indicates a failure
      in coordination. :) In which case, it doesn't really matter how the tag
      is disambiguated.
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      d0b9a7f0
    • Dylan Baker's avatar
      meson: Force the use of config-tool for llvm · 0d594594
      Dylan Baker authored
      meson git now has a cmake find method for llvm, but it lacks a couple of
      features that we use from the config tool version. Until that reaches
      parity we need to use the config-tool version.
      
      CC: 19.0 19.1 <<mesa-stable@lists.freedesktop.org>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      0d594594
    • Brian Paul's avatar
      gallium/util: fix two MSVC compiler warnings · a17c1ae1
      Brian Paul authored
      Remove stray const qualifier.
      s/unsigned/enum tgsi_semantic/
      Reviewed-by: default avatarRoland Scheidegger <sroland@vmware.com>
      a17c1ae1
    • Brian Paul's avatar
    • Brian Paul's avatar
      noop: s/enum pipe_transfer_usage/unsigned/ to fix MSVC warning · cf5c7beb
      Brian Paul authored
      The function pointer declaration in pipe_context uses unsigned
      for the bitmask.
      Reviewed-by: default avatarRoland Scheidegger <sroland@vmware.com>
      cf5c7beb
    • Brian Paul's avatar
      ddebug: fix a few MSVC compiler warnings · bc517dbb
      Brian Paul authored
      Don't return an expression in void functions.
      Replace an unsigned int with proper enum.
      Reviewed-by: default avatarRoland Scheidegger <sroland@vmware.com>
      bc517dbb
    • Brian Paul's avatar
      glsl: s/GLboolean/bool/ to silence MSVC compiler warning · 2e28983e
      Brian Paul authored
      It complains about mixing GLboolean and bool in the |= expression.
      Reviewed-by: default avatarRoland Scheidegger <sroland@vmware.com>
      2e28983e
    • Ian Romanick's avatar
      nir/flrp: Reassociate add in flrp(±1, b, c) lowering path · ed5f0245
      Ian Romanick authored
      With this reassociation, this lowering path is still beneficial.
      
      Ice Lake
      total instructions in shared programs: 17220191 -> 17207181 (-0.08%)
      instructions in affected programs: 999871 -> 986861 (-1.30%)
      helped: 3703
      HURT: 17
      helped stats (abs) min: 1 max: 686 x̄: 3.52 x̃: 3
      helped stats (rel) min: 0.09% max: 51.97% x̄: 2.21% x̃: 1.35%
      HURT stats (abs)   min: 1 max: 9 x̄: 1.47 x̃: 1
      HURT stats (rel)   min: 0.08% max: 4.55% x̄: 0.78% x̃: 0.55%
      95% mean confidence interval for instructions value: -4.01 -2.99
      95% mean confidence interval for instructions %-change: -2.29% -2.11%
      Instructions are helped.
      
      total cycles in shared programs: 360871298 -> 360755040 (-0.03%)
      cycles in affected programs: 9931334 -> 9815076 (-1.17%)
      helped: 2388
      HURT: 1569
      helped stats (abs) min: 1 max: 10228 x̄: 93.54 x̃: 18
      helped stats (rel) min: <.01% max: 74.11% x̄: 3.36% x̃: 1.07%
      HURT stats (abs)   min: 1 max: 1917 x̄: 68.27 x̃: 22
      HURT stats (rel)   min: <.01% max: 44.90% x̄: 3.44% x̃: 1.72%
      95% mean confidence interval for cycles value: -39.48 -19.28
      95% mean confidence interval for cycles %-change: -0.86% -0.46%
      Cycles are helped.
      
      total spills in shared programs: 12355 -> 12159 (-1.59%)
      spills in affected programs: 295 -> 99 (-66.44%)
      helped: 2
      HURT: 1
      
      total fills in shared programs: 25398 -> 25207 (-0.75%)
      fills in affected programs: 288 -> 97 (-66.32%)
      helped: 2
      HURT: 1
      
      LOST:   3
      GAINED: 44
      
      Iron Lake
      total instructions in shared programs: 8169225 -> 8159729 (-0.12%)
      instructions in affected programs: 1025712 -> 1016216 (-0.93%)
      helped: 3352
      HURT: 0
      helped stats (abs) min: 1 max: 6 x̄: 2.83 x̃: 3
      helped stats (rel) min: 0.15% max: 12.00% x̄: 1.51% x̃: 1.05%
      95% mean confidence interval for instructions value: -2.86 -2.80
      95% mean confidence interval for instructions %-change: -1.56% -1.46%
      Instructions are helped.
      
      total cycles in shared programs: 188656796 -> 188612280 (-0.02%)
      cycles in affected programs: 18633584 -> 18589068 (-0.24%)
      helped: 3085
      HURT: 14
      helped stats (abs) min: 2 max: 72 x̄: 14.45 x̃: 12
      helped stats (rel) min: 0.02% max: 5.73% x̄: 0.73% x̃: 0.31%
      HURT stats (abs)   min: 2 max: 4 x̄: 3.71 x̃: 4
      HURT stats (rel)   min: <.01% max: <.01% x̄: <.01% x̃: <.01%
      95% mean confidence interval for cycles value: -14.55 -14.18
      95% mean confidence interval for cycles %-change: -0.76% -0.69%
      Cycles are helped.
      
      GM45
      total instructions in shared programs: 5026905 -> 5021856 (-0.10%)
      instructions in affected programs: 584169 -> 579120 (-0.86%)
      helped: 1776
      HURT: 0
      helped stats (abs) min: 1 max: 6 x̄: 2.84 x̃: 3
      helped stats (rel) min: 0.15% max: 11.11% x̄: 1.43% x̃: 0.98%
      95% mean confidence interval for instructions value: -2.88 -2.80
      95% mean confidence interval for instructions %-change: -1.50% -1.37%
      Instructions are helped.
      
      total cycles in shared programs: 129047376 -> 129018918 (-0.02%)
      cycles in affected programs: 12941924 -> 12913466 (-0.22%)
      helped: 1722
      HURT: 14
      helped stats (abs) min: 4 max: 72 x̄: 16.56 x̃: 18
      helped stats (rel) min: 0.02% max: 5.73% x̄: 0.72% x̃: 0.30%
      HURT stats (abs)   min: 2 max: 4 x̄: 3.71 x̃: 4
      HURT stats (rel)   min: <.01% max: <.01% x̄: <.01% x̃: <.01%
      95% mean confidence interval for cycles value: -16.65 -16.13
      95% mean confidence interval for cycles %-change: -0.76% -0.66%
      Cycles are helped.
      Reviewed-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
      Reviewed-by: Samuel Pitoiset's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
      ed5f0245
    • Ian Romanick's avatar
      nir/flrp: Fix typo on the flrp(±1, b, c) path · ba203a3c
      Ian Romanick authored
      After Samuel reported the bisect, I was able to find the bug by
      inspection.  Good thing for well-named varibles. :)
      
      Unfortunately, this undoes almost all of the benefit of the original
      patch.
      
      Ice Lake
      total instructions in shared programs: 17183159 -> 17218166 (0.20%)
      instructions in affected programs: 1308722 -> 1343729 (2.67%)
      helped: 98
      HURT: 4746
      helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1
      helped stats (rel) min: 0.47% max: 2.70% x̄: 0.60% x̃: 0.57%
      HURT stats (abs)   min: 1 max: 691 x̄: 7.40 x̃: 8
      HURT stats (rel)   min: 0.10% max: 700.00% x̄: 5.82% x̃: 2.83%
      95% mean confidence interval for instructions value: 6.82 7.64
      95% mean confidence interval for instructions %-change: 5.22% 6.15%
      Instructions are HURT.
      
      total cycles in shared programs: 360705959 -> 360853522 (0.04%)
      cycles in affected programs: 10754380 -> 10901943 (1.37%)
      helped: 1594
      HURT: 3331
      helped stats (abs) min: 1 max: 1896 x̄: 119.81 x̃: 60
      helped stats (rel) min: <.01% max: 35.48% x̄: 5.06% x̃: 3.64%
      HURT stats (abs)   min: 1 max: 10208 x̄: 101.63 x̃: 38
      HURT stats (rel)   min: 0.01% max: 878.95% x̄: 9.01% x̃: 2.78%
      95% mean confidence interval for cycles value: 21.11 38.81
      95% mean confidence interval for cycles %-change: 3.76% 5.15%
      Cycles are HURT.
      
      total spills in shared programs: 12158 -> 12355 (1.62%)
      spills in affected programs: 98 -> 295 (201.02%)
      helped: 1
      HURT: 2
      
      total fills in shared programs: 25204 -> 25398 (0.77%)
      fills in affected programs: 94 -> 288 (206.38%)
      helped: 0
      HURT: 3
      
      LOST:   15
      GAINED: 8
      
      Iron Lake
      total instructions in shared programs: 8121430 -> 8166733 (0.56%)
      instructions in affected programs: 1148353 -> 1193656 (3.95%)
      helped: 2
      HURT: 4046
      helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1
      helped stats (rel) min: 1.85% max: 1.92% x̄: 1.89% x̃: 1.89%
      HURT stats (abs)   min: 1 max: 43 x̄: 11.20 x̃: 11
      HURT stats (rel)   min: 0.20% max: 716.67% x̄: 7.40% x̃: 3.87%
      95% mean confidence interval for instructions value: 11.02 11.37
      95% mean confidence interval for instructions %-change: 6.84% 7.94%
      Instructions are HURT.
      
      total cycles in shared programs: 188376326 -> 188601568 (0.12%)
      cycles in affected programs: 27416674 -> 27641916 (0.82%)
      helped: 68
      HURT: 3947
      helped stats (abs) min: 2 max: 222 x̄: 13.88 x̃: 6
      helped stats (rel) min: <.01% max: 1.28% x̄: 0.15% x̃: 0.01%
      HURT stats (abs)   min: 2 max: 670 x̄: 57.31 x̃: 64
      HURT stats (rel)   min: <.01% max: 1811.11% x̄: 4.11% x̃: 1.09%
      95% mean confidence interval for cycles value: 55.01 57.20
      95% mean confidence interval for cycles %-change: 2.88% 5.19%
      Cycles are HURT.
      
      LOST:   35
      GAINED: 3
      
      GM45
      total instructions in shared programs: 4979794 -> 5003551 (0.48%)
      instructions in affected programs: 635174 -> 658931 (3.74%)
      helped: 1
      HURT: 2142
      helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1
      helped stats (rel) min: 1.85% max: 1.85% x̄: 1.85% x̃: 1.85%
      HURT stats (abs)   min: 1 max: 43 x̄: 11.09 x̃: 11
      HURT stats (rel)   min: 0.20% max: 716.67% x̄: 7.00% x̃: 3.53%
      95% mean confidence interval for instructions value: 10.85 11.33
      95% mean confidence interval for instructions %-change: 6.25% 7.74%
      Instructions are HURT.
      
      total cycles in shared programs: 128519586 -> 128654990 (0.11%)
      cycles in affected programs: 17635304 -> 17770708 (0.77%)
      helped: 46
      HURT: 2088
      helped stats (abs) min: 4 max: 220 x̄: 18.13 x̃: 6
      helped stats (rel) min: <.01% max: 1.28% x̄: 0.15% x̃: 0.01%
      HURT stats (abs)   min: 2 max: 670 x̄: 65.25 x̃: 66
      HURT stats (rel)   min: <.01% max: 1464.29% x̄: 4.05% x̃: 0.99%
      95% mean confidence interval for cycles value: 61.75 65.15
      95% mean confidence interval for cycles %-change: 2.58% 5.34%
      Cycles are HURT.
      
      LOST:   38
      GAINED: 38
      
      Fixes: 5b908db6 ("nir/flrp: Lower flrp(±1, b, c) and flrp(a, ±1, c) differently")
      Reported-by: Samuel Pitoiset's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
      Reviewed-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
      Reviewed-by: Samuel Pitoiset's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
      ba203a3c
    • Lionel Landwerlin's avatar
      anv: fix use after free · 43596e5f
      Lionel Landwerlin authored
      Once mem->bo is removed from the cache, it is likely to be freed.
      Signed-off-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Fixes: b80930a6 ("anv: add support for VK_EXT_memory_budget")
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      43596e5f
    • Lionel Landwerlin's avatar
      anv: rework queries writes to ensure ordering memory writes · a07d06f1
      Lionel Landwerlin authored
      We use a mix of MI & PIPE_CONTROL commands to write our queries' data
      (results & availability). Those commands' memory write order is not
      guaranteed with regard to their order in the command stream, unless CS
      stalls are inserted between them. This is problematic for 2 reasons :
      
         1. We copy results from the device using MI commands even though
            the values are generated from PIPE_CONTROL, meaning we could
            copy unlanded values into the results and then copy the
            availability that is inconsistent with the values.
      
         2. We allow the user to poll on the availability values of the
            query pool from the CPU. If the availability lands in memory
            before the values then we could return invalid values.
      
      This change does 2 things to address this problem :
      
            - We use either PIPE_CONTROL or MI commands to write both
              queries values and availability, so that the ordering of the
              memory writes guarantees that if availability is visible,
              results are also visible.
      
            - For the occlusion & timestamp queries we apply a CS stall
              before copying the results on the device, to ensure copying
              with MI commands see the correct values of previous
              PIPE_CONTROL writes of availability (required by the Vulkan
              spec).
      Signed-off-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Reported-by: Iago Toral's avatarIago Toral Quiroga <itoral@igalia.com>
      Cc: mesa-stable@lists.freedesktop.org
      Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
      a07d06f1
    • Timothy Arceri's avatar
      radv: call constant folding before opt algebraic · e19a8fe0
      Timothy Arceri authored
      The pattern of calling opt algebraic first seems to have originated
      in i965. The order in OpenGL drivers generally doesn't matter
      because the GLSL IR optimisations do constant folding before
      opt algebraic.
      
      However in Vulkan drivers calling opt algebraic first can result
      in missed constant folding opportunities.
      
      vkpipeline-db results (VEGA64):
      
      Totals from affected shaders:
      SGPRS: 3160 -> 3176 (0.51 %)
      VGPRS: 3588 -> 3580 (-0.22 %)
      Spilled SGPRs: 52 -> 44 (-15.38 %)
      Spilled VGPRs: 0 -> 0 (0.00 %)
      Private memory VGPRs: 0 -> 0 (0.00 %)
      Scratch size: 12 -> 12 (0.00 %) dwords per thread
      Code Size: 261812 -> 261036 (-0.30 %) bytes
      LDS: 7 -> 7 (0.00 %) blocks
      Max Waves: 346 -> 348 (0.58 %)
      Wait states: 0 -> 0 (0.00 %)
      Reviewed-by: Samuel Pitoiset's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
      Reviewed-by: Bas Nieuwenhuizen's avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      e19a8fe0
    • Erik Faye-Lund 's avatar
      docs: drop h1 in header · ecdab0df
      Erik Faye-Lund authored
      It's generally frowned upon to have more than one H1 per document in
      HTML4. So let's put the text directly inside the header. This means we
      can drop the flex-based centering, which makes things a bit easier. We
      also need to change the padding to rem instead of em, because the em has
      now changed.
      Signed-off-by: Erik Faye-Lund 's avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      ecdab0df
    • Erik Faye-Lund 's avatar
      docs: harmonize headings and titles · 6e0e5509
      Erik Faye-Lund authored
      We're pretty insonsistent in what the headings and titles are, especially
      compared to what the articles are listed as in the sidebar. Let's
      harmonize this.
      
      There's a notable exception for meson.html, where the sidebar uses a
      short-hand form that makes sense in the sidebar, but not in the article
      due to the visible context being different.
      Signed-off-by: Erik Faye-Lund 's avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      6e0e5509
    • Erik Faye-Lund 's avatar
      docs: renumber headings · 269474b4
      Erik Faye-Lund authored
      It's generally frowned upon to have multiple H1 headings in HTML4. So
      let's make sure each article has a primary heading for the article, and
      that that heading is the title that is used in the sidebar.
      
      While we're at it, let's update the title in the articles to match the
      title from the sidebar as well.
      Signed-off-by: Erik Faye-Lund 's avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      269474b4
    • Erik Faye-Lund 's avatar
      docs: give download-article a primary heading · 87683ba0
      Erik Faye-Lund authored
      It's generally frowned upon to have multiple H1 headings in HTML4. So
      let's add a primary heading for the article, and source that from the
      title used in the sidebar.
      
      While we're at it, let's update the title in the article to match the
      title from the sidebar as well.
      Signed-off-by: Erik Faye-Lund 's avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      87683ba0
    • Erik Faye-Lund 's avatar
      docs: use title-casing for all headings in sidebar · a8df27b0
      Erik Faye-Lund authored
      We generally use title-casing for headings in the sidebar. But not
      all headings was constently cased like that. Let's make sure this
      is consistent.
      Signed-off-by: Erik Faye-Lund 's avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Acked-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      a8df27b0