1. 22 Jun, 2022 1 commit
    • Jon Turney's avatar
      Fix Win32 build with -fno-common · 5fe727b1
      Jon Turney authored
      /work/xorg/lib/libX11/src/XlibInt.c:1968: multiple definition of `_Xdebug_p'; .libs/globals.o:globals.c:(.bss+0xc): first defined here
      
      Avoid redundant definition of _Xdebug_p in globals.c (which is under the
      influence of _Xdebug being #defined to _Xdebug_p.
      
      This appears to be an ancient hack to work around data exports resolving
      to the address of the import stub, not the import. (See [1]).
      
      (This is probably no longer needed or can be done in a better way, as
      per the discussion under --enable-auto-import and in the ld manpage.)
      
      [1] https://cygwin.com/pipermail/cygwin-xfree/2001-May/004606.html
      5fe727b1
  2. 15 Jun, 2022 1 commit
  3. 09 Jun, 2022 1 commit
  4. 04 May, 2022 1 commit
  5. 29 Apr, 2022 1 commit
  6. 26 Apr, 2022 1 commit
    • Adam Jackson's avatar
      global: call XInitThreads() from the library's constructor · afcdb6fb
      Adam Jackson authored
      
      
      There is really no point in not being thread safe, I measured, all you
      can see happen is noop performance gets like twice as slow and you have
      thread safety bugs. And we're using xcb as the transport which means we
      should expect threads in our clients anyway. Just do it.
      
      This assumes your compiler understands __attribute__((constructor)). If
      this is not your compiler, you can disable this with the appropriate
      configure flag, but be aware you're asking for bugs.
      
      Signed-off-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      afcdb6fb
  7. 24 Apr, 2022 1 commit
  8. 23 Apr, 2022 3 commits
  9. 20 Apr, 2022 2 commits
  10. 18 Apr, 2022 2 commits
  11. 15 Apr, 2022 2 commits
  12. 10 Apr, 2022 1 commit
    • Alan Coopersmith's avatar
      XkbUpdateKeyTypeVirtualMods: always initialize mask · 6d7d0872
      Alan Coopersmith authored
      
      
      XkbVirtualModsToReal should only fail to set mask if the server does
      not support XKB, but it still made Oracle Parfait complain:
      
      Error: Uninitialised memory
         Uninitialised memory variable [uninitialised-mem-var] (CWE 457):
            Possible access to uninitialised memory referenced by variable 'mask'
              at line 863 of lib/libX11/src/xkb/XKBMisc.c in function 'XkbUpdateKeyTypeVirtualMods'.
              Path in callee avoiding write at line 862
                mask allocated at line 860
      
      Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      6d7d0872
  13. 03 Apr, 2022 2 commits
  14. 30 Mar, 2022 1 commit
  15. 24 Mar, 2022 1 commit
    • Hodong's avatar
      Fix two memory leaks in _XFreeX11XCBStructure() · 8a368d80
      Hodong authored and Matt Turner's avatar Matt Turner committed
      
      
      Even when XCloseDisplay() was called, some memory was leaked.
      
      XCloseDisplay() calls _XFreeDisplayStructure(), which calls
      _XFreeX11XCBStructure().
      
      However, _XFreeX11XCBStructure() did not destroy the condition variables,
      resulting in the leaking of some 40 bytes.
      
      Signed-off-by: default avatarHodong <hodong@yozmos.com>
      8a368d80
  16. 23 Mar, 2022 2 commits
  17. 03 Mar, 2022 1 commit
  18. 25 Feb, 2022 4 commits
  19. 24 Feb, 2022 2 commits
  20. 20 Feb, 2022 2 commits
  21. 14 Feb, 2022 2 commits
  22. 13 Feb, 2022 1 commit
  23. 04 Feb, 2022 1 commit
  24. 03 Feb, 2022 1 commit
  25. 02 Feb, 2022 2 commits
  26. 27 Jan, 2022 1 commit