Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • John Stultz
  • mesamesa
  • Repository

Switch branch/tag
  • mesa
  • src
  • gallium
  • drivers
  • etnaviv
  • etnaviv_screen.c
Find file BlameHistoryPermalink
  • John Stultz's avatar
    etnaviv: Avoid shift overflow · e3bbe1fa
    John Stultz authored Mar 12, 2020
    
    
    Building with AOSP I'm seeing:
    
    external/mesa3d/src/gallium/drivers/etnaviv/etnaviv_screen.c:245:31: error: signed shift result (0x100000000) requires 34 bits to represent, but 'int' only has 32 bits [-Werror,-Wshift-overflow]
             system_memory = 4096 << 20;
    
    system_memory is a uint_64t, so this patch addresses the issue
    by casting 4096 to a unint_64t before the shift is done.
    Reviewed-by: Christian Gmeiner's avatarChristian Gmeiner <christian.gmeiner@gmail.com>
    Signed-off-by: John Stultz's avatarJohn Stultz <john.stultz@linaro.org>
    Part-of: <mesa/mesa!4175>
    e3bbe1fa

Replace etnaviv_screen.c

Attach a file by drag & drop or click to upload


Cancel
GitLab will create a branch in your fork and start a merge request.