Commits · 041369419ff3818ffbeb6451aeefd1a69e7db8dc · Jakub Jelen / libcacard

26 Apr, 2020 8 commits

vcard_emul_nss: Fix parameter name in usage documentation · 04136941
Jakub Jelen authored Apr 21, 2020 and Frediano Ziglio committed Apr 26, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
04136941
fuzz_options: Clean up allocated memory · 9690b944
Jakub Jelen authored Apr 20, 2020 and Frediano Ziglio committed Apr 26, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
9690b944
Fuzzer for options parser · e392f893
Jakub Jelen authored Apr 20, 2020 and Frediano Ziglio committed Apr 26, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
e392f893
vcard_emul_nss: Avoid redefinition of already set options · a3b0f336
Jakub Jelen authored Apr 20, 2020 and Frediano Ziglio committed Apr 26, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
a3b0f336
vcard_emul_nss: Clean up memory · e58b911d
Jakub Jelen authored Apr 20, 2020 and Frediano Ziglio committed Apr 26, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
e58b911d
vcard_emul_nss: Do not use const char for something changable · 9d352ecd
Jakub Jelen authored Apr 20, 2020 and Frediano Ziglio committed Apr 26, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
9d352ecd

vcard_emul_nss: Avoid null deref when parsing options · aebeee08

Jakub Jelen authored Apr 20, 2020 and

Frediano Ziglio committed Apr 26, 2020



Error from fuzzer:

==7==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000004e1a32 bp 0x7ffdf742d050 sp 0x7ffdf742cfa0 T0)
==7==The signal is caused by a READ memory access.
==7==Hint: address points to the zero page.
SCARINESS: 10 (null-deref)
    #0 0x4e1a32 in vcard_emul_options /work/meson/../../src/libcacard/src/vcard_emul_nss.c:1282:13
    #1 0x4cb79e in LLVMFuzzerTestOneInput /work/meson/../../src/libcacard/fuzz/fuzz_options.c:54:15
[...]
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

aebeee08

Fuzz also simpletlv parser · 0424cfbe

Jakub Jelen authored Apr 20, 2020 and

Frediano Ziglio committed Apr 26, 2020



The parser is not covered as it is used for parsing output of real
cards (which are not available in tests and emulation).
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

0424cfbe

17 Apr, 2020 16 commits

tests: New tests of initialization · 80633536
Jakub Jelen authored Apr 16, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
80633536

Add first simple fuzzer · 57deaec6

Jakub Jelen authored Dec 15, 2019 and

Frediano Ziglio committed Apr 17, 2020

Per [1], we are good to go to integrate in oss-fuzz. This adds
aa simple fuzzer and some housekeeping/preparatory work around
build system to be able to build fuzzers for oss-fuzz.

The fuzzers can be built only with new meson build system as
trying to make it working with autotools was quite a pain.

The oss-fuzz is already running on my fork temporarily, before
this will be merged as in [2].

[1] https://github.com/google/oss-fuzz/pull/3019
[2] https://github.com/google/oss-fuzz/pull/3466

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

57deaec6

Avoids some code duplication · 358e2d8b

Frediano Ziglio authored Apr 17, 2020



Call NSS_InitContext and handle its result once.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Jakub Jelen <jjelen@redhat.com>

358e2d8b

Cache g_get_system_config_dirs results · 936519e5

Frediano Ziglio authored Apr 17, 2020



Do not call the function 3 times in a row.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Jakub Jelen <jjelen@redhat.com>

936519e5

vcard_emul_nss: Avoid memory leaks by properly freeing all references · 30bdd7c9
Jakub Jelen authored Mar 10, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
30bdd7c9
Generate new NSS DB for tests · 1b03307d
Jakub Jelen authored Mar 09, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
1b03307d
Use the new finalize API in tools and tests and refactor the order of the calls in cleanup · 42475d4c
Jakub Jelen authored Mar 06, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
42475d4c
vcard_emul_nss: Use NSS_{Init,Shutdown}Context() functions to avoid messing with not owned contexts · a9fb4177
Jakub Jelen authored Apr 16, 2020 and Frediano Ziglio committed Apr 17, 2020
```
As recommended by the NSS wiki:

https://wiki.mozilla.org/NSS_Library_Init

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
a9fb4177
Introduce new API for cleanup · 177d55df
Jakub Jelen authored Mar 06, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
177d55df
Do not attempt to run HW tests without all dependencies · fd2e0949
Jakub Jelen authored Mar 05, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
fd2e0949
meson: Allow building static libraries · f920d8c5
Jakub Jelen authored Mar 05, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
f920d8c5
meson: Add an option do skip tests · 954d4ca5
Jakub Jelen authored Mar 05, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
954d4ca5
meson: The libcacard test does not require softhsm · 6c82a8e4
Jakub Jelen authored Mar 04, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
6c82a8e4
vcard_emul_nss: Log message if the NSS_Init fails (with db dir used) · e63bc9f3
Jakub Jelen authored Mar 04, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
e63bc9f3
Fix link to contribution documentation · 243d1164
Jakub Jelen authored Mar 03, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
243d1164
gitlab-ci: Run also tests from meson · af251faa
Jakub Jelen authored Mar 03, 2020 and Frediano Ziglio committed Apr 17, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
af251faa

03 Feb, 2020 3 commits

ci: Rename "meson" job to "Fedora meson" · aa49fabb

Frediano Ziglio authored Jan 31, 2020



All other job names start with the distribution name.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

aa49fabb

build: Clean unwanted files packaging the distribution · a56873fa

Frediano Ziglio authored Jan 29, 2020



Remove CI files and other not necessary files.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

a56873fa

build: Generate ChangeLog like autoconf · 9fd0f50a

Frediano Ziglio authored Jan 29, 2020



Instead of generating THANKS, generate ChangeLog like autoconf does.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

9fd0f50a

29 Jan, 2020 2 commits

build-sys: add meson · f0bf1b44

Marc-André Lureau authored Jan 15, 2020 and

Frediano Ziglio committed Jan 29, 2020

autotools is left for now, for a small transition period, and to cover
win32 when either p11 backend is added or nss is packaged again in mingw.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

f0bf1b44

Fix -Wunused-parameter warnings · 9f19c8f1
Marc-André Lureau authored Jan 29, 2020 and Frediano Ziglio committed Jan 29, 2020
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
9f19c8f1

27 Jan, 2020 3 commits
- setup-softhsm2: Try to find library on Ubuntu · 0fc45266
  Jakub Jelen authored Jan 23, 2020 and Frediano Ziglio committed Jan 27, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
  0fc45266
- Add Ubuntu target to catch different issues · 48c4dea8
  Jakub Jelen authored Jan 23, 2020 and Frediano Ziglio committed Jan 27, 2020
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
  48c4dea8
- Properly add glib dependency to unbreak vsclient and tests build on Ubuntu · 383dfad4
  Jakub Jelen authored Jan 23, 2020
```
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
```
  383dfad4
24 Jan, 2020 1 commit
- build-sys: remove unused LIBCACARD_COMPILATION · 83c87e0a
  Marc-André Lureau authored Jan 23, 2020 and Frediano Ziglio committed Jan 24, 2020
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
  83c87e0a
23 Jan, 2020 2 commits
- libcacard.pc.in: improve description · 8c65e930
  Marc-André Lureau authored Jan 22, 2020 and Frediano Ziglio committed Jan 23, 2020
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
  8c65e930
- build-sys: improve --disable-pcsc help · b0ab359d
  Marc-André Lureau authored Jan 22, 2020 and Frediano Ziglio committed Jan 23, 2020
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
```
  b0ab359d
22 Jan, 2020 1 commit

tests: fix shebang · 2e8eef9d

Marc-André Lureau authored Jan 22, 2020 and

Frediano Ziglio committed Jan 22, 2020


Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

2e8eef9d

21 Jan, 2020 1 commit

build-sys: bump glib dependency to 2.32 · 6e456bf6

Marc-André Lureau authored Jan 15, 2020 and

Frediano Ziglio committed Jan 21, 2020



Since version 2.32, gthread is an empty shell, and g_thread_init() is
no longer required.

GLib 2.32 was released on 2012-03-24, and is available in all distros
we care about.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

6e456bf6

02 Dec, 2019 3 commits
- Add CII Best Practices Badge · d276f5a0
  Jakub Jelen authored Dec 02, 2019
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
```
  d276f5a0
- README: Add high-level description of the libcacard project · 2f20d62e
  Jakub Jelen authored Dec 02, 2019
```
and links to other documents inside
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
```
  2f20d62e
- Clarify contributor guidelines · 4efc0459
  Jakub Jelen authored Dec 02, 2019
```
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
```
  4efc0459