Commit f7d1bf07 authored by Tapani Pälli's avatar Tapani Pälli Committed by Marge Bot
Browse files

glsl: fix a memory leak with resource_set

   ==7265== 248 (120 direct, 128 indirect) bytes in 1 blocks are definitely lost in loss record 1,438 of 1,465
   ==7265==    at 0x483980B: malloc (vg_replace_malloc.c:309)
   ==7265==    by 0x598A2AB: ralloc_size (ralloc.c:119)
   ==7265==    by 0x598F861: _mesa_set_create (set.c:127)
   ==7265==    by 0x599079D: _mesa_pointer_set_create (set.c:570)
   ==7265==    by 0x58BD7D1: build_program_resource_list(gl_context*, gl_shader_program*, bool) (linker.cpp:4026)
   ==7265==    by 0x548231B: st_link_shader (st_glsl_to_ir.cpp:170)
   ==7265==    by 0x54DA269: _mesa_glsl_link_shader (ir_to_mesa.cpp:3119)

Fixes: a6aedc66

 ("st/glsl_to_nir: use nir based program resource list builder")
Signed-off-by: Tapani Pälli's avatarTapani Pälli <tapani.palli@intel.com>
Reviewed-by: Timothy Arceri's avatarTimothy Arceri <tarceri@itsqueeze.com>
Tested-by: Marge Bot <mesa/mesa!3574>
Part-of: <mesa/mesa!3574>
parent 556c9401
......@@ -4040,8 +4040,10 @@ build_program_resource_list(struct gl_context *ctx,
return;
}
if (add_packed_varyings_only)
if (add_packed_varyings_only) {
_mesa_set_destroy(resource_set, NULL);
return;
}
if (!add_fragdata_arrays(ctx, shProg, resource_set))
return;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment