Commit 0350f0e7 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

CONTRIBUTING: commit rights docs

This tries to align with the communities's long-standing
tradition of trying to be an inclusive community and handing out
commit rights fairly freely.

We also tend to not revoke commit rights for people no longer
regularly active in a given project, as long as they're still part of
the larger community.

Finally make sure that commit rights, like anything happening on fd.o
infrastructre, is subject to the fd.o's Code of Conduct.

v2: Point at MAINTAINERS for contact info (Daniel S.)

- Make it clear that commit rights are voluntary and that committers
  need to acknowledge positively when they're nominated by someone
  else (Keith).
- Encourage committers to drop their commit rights when they're no
  longer active, and make it clear they'll get readded (Keith).
- Add a line that maintainers and committers should actively nominate
  new committers (me).

v4: Typo (Petri).

v5: Typo (Sean).

v6: Wording clarifications and spelling (Jani).

v7: Require an explicit commitment to the documented merge criteria
and rules, instead of just the implied one through the Code of Conduct
threat (Jani).
Acked-by: default avatarAlex Deucher <>
Acked-by: default avatarArkadiusz Hiler <>
Acked-by: Daniel Stone's avatarDaniel Stone <>
Acked-by: Emma Anholt's avatarEric Anholt <>
Acked-by: Gustavo Padovan's avatarGustavo Padovan <>
Acked-by: Petri Latvala's avatarPetri Latvala <>
Cc: Alex Deucher <>
Cc: Arkadiusz Hiler <>
Cc: Ben Widawsky <>
Cc: Daniel Stone <>
Cc: Dave Airlie <>
Cc: Eric Anholt <>
Cc: Gustavo Padovan <>
Cc: Jani Nikula <>
Cc: Joonas Lahtinen <>
Cc: Keith Packard <>
Cc: Kenneth Graunke <>
Cc: Kristian H. Kristensen <>
Cc: Maarten Lankhorst <>
Cc: Petri Latvala <>
Cc: Rodrigo Vivi <>
Cc: Sean Paul <>
Reviewed-by: Keith Packard's avatarKeith Packard <>
Signed-off-by: Daniel Vetter's avatarDaniel Vetter <>
Acked-by: Harry Wentland's avatarHarry Wentland <>
Acked-by: Sean Paul's avatarSean Paul <>
parent e5e8dafc
......@@ -51,4 +51,52 @@ A short list of contribution guidelines:
- Changes to the testcases are automatically tested. Take the results into
account before merging.
Commit rights
Commit rights will be granted to anyone who requests them and fulfills the
below criteria:
- Submitted a few (5-10 as a rule of thumb) non-trivial (not just simple
spelling fixes and whitespace adjustment) patches that have been merged
- Are actively participating on discussions about their work (on the mailing
list or IRC). This should not be interpreted as a requirement to review other
peoples patches but just make sure that patch submission isn't one-way
communication. Cross-review is still highly encouraged.
- Will be regularly contributing further patches. This includes regular
contributors to other parts of the open source graphics stack who only
do the oddball rare patch within igt itself.
- Agrees to use their commit rights in accordance with the documented merge
criteria, tools, and processes.
Apply for an account (and any other account change requests) through
and please ping the maintainers if your request is stuck.
Committers are encouraged to request their commit rights get removed when they
no longer contribute to the project. Commit rights will be reinstated when they
come back to the project.
Maintainers and committers should encourage contributors to request commit
rights, especially junior contributors tend to underestimate their skills.
Code of Conduct
Please be aware the fd.o Code of Conduct also applies to igt:
See the MAINTAINERS file for contact details of the igt maintainers.
Abuse of commit rights, like engaging in commit fights or willfully pushing
patches that violate the documented merge criteria, will also be handled through
the Code of Conduct enforcement process.
Happy hacking!
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment