1. 26 Feb, 2019 3 commits
  2. 21 Feb, 2019 2 commits
  3. 20 Feb, 2019 2 commits
  4. 19 Feb, 2019 2 commits
    • Victor Toso's avatar
      tests: use GPOINTER_TO_INT to avoid warnings with mingw · 1012e3d8
      Victor Toso authored
      New casts to avoid the the warnings mentioned below. While at it, move
      some existing casts (introduced at 61bc9091) to use
      GPOINTER_TO_INT too.
      
      [458/673] Compiling C object 'tests/check/7d01337@@libs_video@exe/libs_video.c.obj'.
      ../tests/check/libs/video.c: In function 'fourcc_get_size':
      ../tests/check/libs/video.c:160:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         return (unsigned long) p->endptr;
                ^
      
      In file included from ../tests/check/libs/video.c:32:
      ../tests/check/libs/video.c: In function 'test_video_formats':
      ../tests/check/libs/video.c:563:39: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         fail_unless_equals_int (size, (unsigned long) paintinfo.endptr);
         ^
      
      And more.
      
      gstreamer/gst-plugins-base!94
      1012e3d8
    • Victor Toso's avatar
      tests: fix compiler warnings on Windows with mingw · c7fe0ed6
      Victor Toso authored
      With commit 3f184c3a, the gst_dir variable becomes unusable in
      windows build. Moving it to linux scope to avoid warning:
      
          [433/673] Compiling C object 'tests/check/7d01337@@libs_profile@exe/libs_profile.c.obj'.
          ../tests/check/libs/profile.c: In function 'profile_suite':
          ../tests/check/libs/profile.c:688:10: warning: unused variable 'gst_dir' [-Wunused-variable]
             gchar *gst_dir;
                   ^~~~~~~
      
      Also fix a typo in the comment.
      c7fe0ed6
  5. 18 Feb, 2019 3 commits
  6. 16 Feb, 2019 1 commit
  7. 15 Feb, 2019 1 commit
  8. 13 Feb, 2019 1 commit
  9. 11 Feb, 2019 3 commits
  10. 08 Feb, 2019 2 commits
  11. 06 Feb, 2019 3 commits
  12. 05 Feb, 2019 1 commit
  13. 04 Feb, 2019 1 commit
    • Guillaume Desmottes's avatar
      videodecoder: remove useless code in negotiate_default_caps() · f5a11645
      Guillaume Desmottes authored
      gst_video_decoder_negotiate_default_caps() is meant to pick a default output
      format when we need one earlier because of an incoming GAP.
      It tries to use the input caps as a base if available and fallback to a default
      format (I420 1280x720@30) for the missing fields.
      
      But the framerate and pixel-aspect were not explicitly passed to
      gst_video_decoder_set_output_state() which is solely relying on the input format
      as reference to get the framerate anx pixel-aspect-ratio.
      So there is no need to manually handling those two fields as
      gst_video_decoder_set_output_state() will already use the ones from
      upstream if available, and they will be ignored anyway if there are not.
      
      This also prevent confusing debugging output where we claim to use a
      specific framerate while actually none was set.
      f5a11645
  14. 31 Jan, 2019 1 commit
  15. 30 Jan, 2019 3 commits
  16. 29 Jan, 2019 8 commits
    • Thibault Saunier's avatar
    • mrk501's avatar
      audioringbuffer: Fix wrong memcpy address when reordering channels · 36183597
      mrk501 authored
      When using multichannel audio data and being needed to reorder channels,
      audio data is not copied correctly because destination address of
      memcpy is wrong.
      
      For example, the following command
      $ gst-launch-1.0 pulsesrc ! audio/x-raw,channels=6,format=S16LE ! filesink location=test.raw
      will reproduce this issue if there is 6-ch audio input device.
      
      This commit fixes that.
      
      The detailed process of this issue is as follows:
      1. gst-launch-1.0 calls gst_pulsesrc_prepare (gst-plugins-good/ext/pulse/pulsesrc.c)
      
         1466 gst_pulsesrc_prepare (GstAudioSrc * asrc, GstAudioRingBufferSpec * spec)
         1467 {
         (skip...)
         1480   {
         1481     GstAudioRingBufferSpec s = *spec;
         1482     const pa_channel_map *m;
         1483
         1484     m = pa_stream_get_channel_map (pulsesrc->stream);
         1485     gst_pulse_channel_map_to_gst (m, &s);
         1486     gst_audio_ring_buffer_set_channel_positions (GST_AUDIO_BASE_SRC
         1487         (pulsesrc)->ringbuffer, s.info.position);
         1488   }
      
         In my environment, after line 1485 is processed, position of spec and s are
           spec->info.position[0] = 0
           spec->info.position[1] = 1
           spec->info.position[2] = 2
           spec->info.position[3] = 6
           spec->info.position[4] = 7
           spec->info.position[5] = 8
      
           s.info.position[0] = 0
           s.info.position[1] = 6
           s.info.position[2] = 2
           s.info.position[3] = 1
           s.info.position[4] = 7
           s.info.position[5] = 8
      
         The values of spec->info.positions equal
         GST_AUDIO_BASE_SRC(pulsesrc)->ringbuffer->spec->info.positions.
      
      2. gst_audio_ring_buffer_set_channel_positions calls
         gst_audio_get_channel_reorder_map.
      
      3. Arguments of gst_audio_get_channel_reorder_map are
          from = s.info.position
          to = GST_AUDIO_BASE_SRC(pulsesrc)->ringbuffer->spec->info.positions
      
         At the end of this function, reorder_map is set to
           reorder_map[0] = 0
           reorder_map[1] = 3
           reorder_map[2] = 2
           reorder_map[3] = 1
           reorder_map[4] = 4
           reorder_map[5] = 5
      
      4. Go back to gst_audio_ring_buffer_set_channel_positions and
         2065       buf->need_reorder = TRUE;
         is processed.
      
      5. Finally, in gst_audio_ring_buffer_read,
      
         1821     if (need_reorder) {
         (skip...)
         1829           memcpy (data + i * bpf + reorder_map[j] * bps, ptr + j * bps, bps);
      
         is processed and makes this issue.
      36183597
    • Sebastian Dröge's avatar
    • Sebastian Dröge's avatar
      rtspconnection: Handle EOF on writev() after checking for all other error conditions · 8a54cc3b
      Sebastian Dröge authored
      Otherwise we would return EOF if nothing was written in any case, even
      if this was actually a case of TIMEOUT or EWOULDBLOCK for example.
      
      Thanks to Edward Hervey for debugging and finding this issue.
      8a54cc3b
    • Ognyan Tonchev's avatar
      rtspconnection: Fixes for corrupt RTP packets in dispatch_write() · 87a9f2b9
      Ognyan Tonchev authored
      Fixes 2 problems:
      
      1) Number of unmapped memories does not always match number of mmaped ones in
      dispatch_write().
      2) When dispatch_write() is dispatched second time after an incomplete write,
      already set offsets will not be taken into account, thus corrupt RTP data will
      be sent.
      87a9f2b9
    • Sebastian Dröge's avatar
      rtsp-connection: Make use of new GstRTSPMessage API for directly storing a... · f90dac8d
      Sebastian Dröge authored
      rtsp-connection: Make use of new GstRTSPMessage API for directly storing a body buffer and add API for writing multiple messages
      
      By doing so we can send a whole GstBufferList and each memory in the
      contained buffers without copying into a single memory area and with a
      single writev() call. This improves performance considerably for
      high-packet-rate streams.
      
      This depends on https://gitlab.gnome.org/GNOME/glib/merge_requests/333
      to be efficient, otherwise each chunk of memory is a separate write()
      call.
      
      gstreamer/gst-plugins-base#370
      f90dac8d
    • Sebastian Dröge's avatar
      rtsp-message: Add support for storing GstBuffers directly as body payload of messages · b3c0d8b8
      Sebastian Dröge authored
      This makes it unnecessary for callers to first merge together all
      memories, and it allows API like GstRTSPConnection to write them out
      without first copying all memories together or using writev()-style API
      to write multiple memories out in one go.
      
      Fixes gstreamer/gst-plugins-base#370
      b3c0d8b8
    • Andrew Gall's avatar
      3a9148b3
  17. 28 Jan, 2019 2 commits
  18. 24 Jan, 2019 1 commit