flvmux: Correct breaks in gst_flv_mux_find_best_pad
The code seems to use `continue` and `break` as if both refer to the surrounding `while` loop. But because `break` breaks out of the `switch`, they actually have the same effect. This may have caused the loop not to terminate when it should. E.g. when `skip_backwards_streams` drops a buffer we should abort the aggregation and wait for all pads to be filled again. Instead, we might have just selected a subsequent pad as our new "best". Replace `break` with `done = TRUE; break`, and `continue` with `break`. Then simplify the code a bit. Part-of: <gstreamer/gst-plugins-good!710>
| Status | Job ID | Name | Coverage | ||||||
|---|---|---|---|---|---|---|---|---|---|
| Build Docker | |||||||||
| passed |
#4331576
|
alpine amd64 manifest builder docker |
00:00:34
|
|
|||||
| passed |
#4331575
|
android docker |
00:00:30
|
|
|||||
| passed |
#4331574
|
cerbero fedora amd64 docker |
00:00:33
|
|
|||||
| passed |
#4331573
|
fedora amd64 docker |
00:00:34
|
|
|||||
| passed |
#4331577
|
gst-indent amd64 docker |
00:00:33
|
|
|||||
| Preparation | |||||||||
| passed |
#4331579
|
gst indent |
00:00:13
|
|
|||||
| passed |
#4331578
|
manifest |
00:00:25
|
|
|||||
| Build | |||||||||
| passed |
#4331588
gstreamer
|
build cerbero cross-android universal |
00:12:01
|
|
|||||
| passed |
#4331592
gst-ios-13.2
|
build cerbero cross-ios universal |
00:20:20
|
|
|||||
| passed |
#4331589
gstreamer
|
build cerbero cross win32 |
00:05:38
|
|
|||||
| passed |
#4331590
gstreamer
|
build cerbero cross win64 |
00:05:32
|
|
|||||
| passed |
#4331587
gstreamer
|
build cerbero fedora x86_64 |
00:05:51
|
|
|||||
| passed |
#4331591
gst-macos-10.15
|
build cerbero macos x86_64 |
00:11:25
|
|
|||||
| passed |
#4331583
|
build clang fedora x86_64 |
00:06:27
|
|
|||||
| manual |
#4331586
1809
windows
docker
allowed to fail
manual
|
build msys2 |
|
||||||
| passed |
#4331580
|
build nodebug fedora x86_64 |
00:06:16
|
|
|||||
| passed |
#4331581
|
build static fedora x86_64 |
00:06:16
|
|
|||||
| passed |
#4331582
|
build static nodebug fedora x86_64 |
00:06:15
|
|
|||||
| passed |
#4331584
1809
windows
docker
|
build vs2017 amd64 |
00:07:42
|
|
|||||
| passed |
#4331585
1809
windows
docker
|
build vs2017 x86 |
00:07:30
|
|
|||||
| Test | |||||||||
| passed |
#4331947
gstreamer
|
check fedora |
00:05:28
|
|
|||||
| passed |
#4331594
gstreamer
|
integration testsuites fedora 1/4 |
00:13:47
|
|
|||||
| passed |
#4331595
gstreamer
|
integration testsuites fedora 2/4 |
00:15:30
|
|
|||||
| passed |
#4331596
gstreamer
|
integration testsuites fedora 3/4 |
00:12:59
|
|
|||||
| passed |
#4331597
gstreamer
|
integration testsuites fedora 4/4 |
00:13:29
|
|
|||||
| passed |
#4331599
gstreamer
|
valgrind bad |
00:05:42
|
|
|||||
| passed |
#4331600
gstreamer
|
valgrind ges |
00:06:54
|
|
|||||
| passed |
#4331598
gstreamer
|
valgrind good |
00:09:26
|
|
|||||
| failed |
#4331593
gstreamer
|
check fedora |
00:08:00
|
|
|||||
| Integrate | |||||||||
| passed |
#4331601
|
cross-android universal examples |
00:07:46
|
|
|||||
| passed |
#4331603
gst-ios-13.2
|
cross-ios universal examples |
00:01:17
|
|
|||||
| passed |
#4331602
|
documentation |
00:10:53
|
|
|||||