Commit 561afb51 authored by Haihao Xiang's avatar Haihao Xiang
Browse files

msdkvpp: close the current VPP session if this session has been initialized

Otherwise MFXVideoVPP_Init will fail because it is called twice without
a close.

Example pipeline:

gst-launch-1.0 videotestsrc ! msdkvpp ! glimagesink

Sometimes glimagesink emits GST_EVENT_RECONFIGURE event which results
in that MFXVideoVPP_Init is called twice, then get the negotiation
failure below:

0:00:00.093715518 21218 0x558ef56231e0 ERROR                msdkvpp
gstmsdkvpp.c:995:gst_msdkvpp_initialize:<msdkvpp0> Init failed
(undefined behavior)
WARNING: from element /GstPipeline:pipeline0/GstMsdkVPP:msdkvpp0: not

After applying this commit, the pipeline above may run without
negotiation failure, however NV12 layout in dmabuf mode is selected in
renegotiation, the display image is corrupted due to the NV12 issue which
was mentioned in commit 3f2314a1. Some other fixes are needed to avoid
renegotiation by default
parent 908db4de
...@@ -904,6 +904,13 @@ gst_msdkvpp_initialize (GstMsdkVPP * thiz) ...@@ -904,6 +904,13 @@ gst_msdkvpp_initialize (GstMsdkVPP * thiz)
session = gst_msdk_context_get_session (thiz->context); session = gst_msdk_context_get_session (thiz->context);
/* Close the current session if the session has been initialized,
* otherwise the subsequent function call of MFXVideoVPP_Init() will
* fail
if (thiz->initialized)
MFXVideoVPP_Close (session);
if (thiz->use_video_memory) { if (thiz->use_video_memory) {
gst_msdk_set_frame_allocator (thiz->context); gst_msdk_set_frame_allocator (thiz->context);
thiz->param.IOPattern = thiz->param.IOPattern =
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment