Skip to content
  • Tim-Philipp Müller's avatar
    libs: fix 'inconsistent DLL linkage' warnings on Windows · 46ed0f04
    Tim-Philipp Müller authored
    For each lib we build export its own API in headers when we're
    building it, otherwise import the API from the headers.
    
    This fixes linker warnings on Windows when building with MSVC.
    
    The problem was that we had defined all GST_*_API decorators
    unconditionally to GST_EXPORT. This was intentional and only
    supposed to be temporary, but caused linker warnings because
    we tell the linker that we want to export all symbols even
    those from externall DLLs, and when the linker notices that
    they were in external DLLS and not present locally it warns.
    
    What we need to do when building each library is: export
    the library's own symbols and import all other symbols. To
    this end we define e.g. BUILDING_GST_FOO and then we define
    the GST_FOO_API decorator either to export or to import
    symbols depending on whether BUILDING_GST_FOO is set or not.
    That way external users of each library API automatically
    get the import.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797185
    46ed0f04