Skip to content
  • Charlie Turner's avatar
    debugutils: Skip multiqueue stats in dot dump · e310a738
    Charlie Turner authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
    If this is not done, tools like xdot fail with "unexpected char
    b'\\'". This is a regression caused by commit
    74938f07 (multiqueue: Add stats
    property).
    
    The deserialized value coming out of g_object_get_property looks like
    this,
    
    $24 = (gchar *) 0x7f560c0046a0 "application/x-gst-multi-queue-stats, queues=(structure)< \\\"queue_0\\\\,\\\\ buffers\\\\=\\\\(uint\\\\)39\\\\,\\\\ bytes\\\\=\\\\(uint\\\\)8
    120251\\\\,\\\\ time\\\\=\\\\(guint64\\\\)1460000000\\\\;\\\", \\\"queue_1\\\\,\\\\ buffers\\\\=\\\\(uint\\\\)186\\\\,\\\\ bytes\\\\=\\\\(uint\\\\)838020\\\\,\\\\ time\\\\=\
    \\\(guint64\\\\)1984000002\\\\;\\\" >;"
    
    That is immediately looking wrong. I don't know enough about GNOME
    serialization details to say with confidence what happened here. It
    gets worse after this is sent through g_strescape and then written to
    the dot file. Interestingly, dot -Tpng is fine to ignore them it
    seems.
    
    Since the stats are by definition verbose, I decided the best choice
    to omit them from the dot file, since such details are not of interest
    there.
    
    Part-of: <!442>
    e310a738